Fix: Register hashchange event more cautiously. #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registering a callback for the "hashchange" event should not occur, before the $.deck plugin was used by the consumer. Otherwise it will be executed, even if there are no slides to actually operate on.
JohnRandom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registering a callback for the "hashchange" event should not occur, before the $.deck plugin was used by the consumer. Otherwise it will be executed, even if there are no slides to actually operate on.
I experienced this behaviour (let's call it a bug) in an app where hash changes did occur before the deck plugin was initialised. This seems to be limited to single page apps, where a dependency can be loaded, before
$.deck( ... )was being called.