No-login trial period#54
Open
DarrenJiaImbue wants to merge 7 commits into
Open
Conversation
Collaborator
|
From testing:
|
| case 'skipAuth': { | ||
| // "Skip for now" — sign in anonymously so the user can use Bouncer | ||
| // without a Google/Apple account. | ||
| if (process.env.HAS_IMBUE_BACKEND !== 'true') { |
Collaborator
There was a problem hiding this comment.
Why is this being checked? I don't get why this should make the "skip" button fail
Collaborator
There was a problem hiding this comment.
if this was an issue it would be handled elsewhere ? so we could just delete
| // the limit, prompt every content tab to sign in. | ||
| const isIOS = typeof window !== 'undefined' | ||
| && typeof (window as unknown as Record<string, unknown>).__ff_getAppCheckToken === 'function'; | ||
| if (evalResult.shouldHide && !isIOS && isAnonymousUser()) { |
Collaborator
There was a problem hiding this comment.
Note for the future: we should handle differences in iOS vs Chrome vs Android in a more centralized way
| console.log('[Bouncer] Launching Google sign-in...'); | ||
| const response: { success?: boolean } = await chrome.runtime.sendMessage({ type: 'launchAuth' }); | ||
| if (response?.success) { | ||
| // Real Google sign-in — clears the guest gate permanently. |
Collaborator
There was a problem hiding this comment.
Note from irl discussion: this doesn't entirely clear the guest gate. To do this you need to start a new websocket with the new google-account-connected Firebase token.
Collaborator
|
fixed gray UI, renewed websocket on sign-in |
Adds a small grey "Skip for now" text button under the Google/Apple sign-in button on the startup screen, letting users access Bouncer without a Google/Apple account via Firebase anonymous auth. - auth.ts: add signInAnon() using Firebase signInAnonymously - auth.stub.ts: matching no-op for no-backend builds - background/index.ts: handle new 'skipAuth' message, broadcast auth state - types.ts: add 'skipAuth' to the message union - content/ui.ts: render skip button in both sign-in prompts, wire skipSignIn() - content.css: style .skip-signin-btn (theme-aware grey text) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Anonymous ("Skip for now") users can now filter 300 posts before being
prompted to sign in, instead of 3.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cinxw
force-pushed
the
cinxw/anonymous-trial
branch
from
5e09398 to
baf4b1f
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
|
Frontend code looks good to me, now looking at backend code. Don't merge yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.