Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace usage of EmberError with native Error #234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gilest
Copy link
Contributor

@gilest gilest commented Jun 13, 2023

Required for Ember 5 support as this v4 deprecation was removed in v5.

Reference on Ember Deprecations:

Use of @ember/error is deprecated. This package merely re-exports the native Error class. You should replace any uses of @ember/error with the native Error.

@gilest gilest requested a review from a team as a code owner June 13, 2023 01:12
@commit-lint
Copy link

commit-lint bot commented Jun 13, 2023

Chore

  • replace usage of EmberError with native Error (a650db0)

Contributors

gilest

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@gilest
Copy link
Contributor Author

gilest commented Jun 21, 2023

@sherwinski @atlawrie could we review this please

@sherwinski
Copy link
Contributor

Hey @gilest, I'm going to defer to @luqven to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants