improved logging of backupService

Issue #211
imixs · Jul 16, 2024 · 6c692e7 · 6c692e7
1 parent e7166f5
commit 6c692e7
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/imixs-archive-backup/src/main/java/org/imixs/archive/backup/BackupService.java b/imixs-archive-backup/src/main/java/org/imixs/archive/backup/BackupService.java
@@ -220,8 +220,7 @@ public void onTimeout(jakarta.ejb.Timer _timer) {
                     } catch (InvalidAccessException | EJBException | BackupException | RestAPIException e) {
                         // we also catch EJBExceptions here because we do not want to cancel the
                         // ManagedScheduledExecutorService
-                        logController.warning(BackupApi.TOPIC_BACKUP,
-                                "SnapshotEvent " + id + " backup failed: " + e.getMessage());
+                        logController.warning(BackupApi.TOPIC_BACKUP, "SnapshotEvent " + id + ": " + e.getMessage());
                         errors++;
                         countMetric(METRIC_EVENTS_ERRORS);
 
@@ -325,9 +324,9 @@ public ItemCollection pullSnapshot(ItemCollection eventLogEntry, DocumentClient
             }
 
         } catch (RuntimeException e) {
-            // can occur in case of a 404
-            logController.warning(BackupApi.TOPIC_BACKUP, "Failed to pull Snapshot " + ref + " -> " + e.getMessage());
-            throw new BackupException("REMOTE_EXCEPTION", "Failed to pull Snapshot: " + e.getMessage(), e);
+            // can occur in rare cases on the ejb container
+            throw new BackupException("REMOTE_EXCEPTION", "Failed to pull Snapshot " + ref + " -> " + e.getMessage(),
+                    e);
         }
         return null;
     }