Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "deprecated-declarations" warnings #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juanvallejo
Copy link

Before

$ go build examples/transcoder.go
# github.com/imkira/go-libav/avcodec
avcodec/avcodec.go: In function ‘_cgo_a038601aec5c_Cfunc_av_bitstream_filter_close’:
avcodec/avcodec.go:162:2: warning: ‘av_bitstream_filter_close’ is deprecated [-Wdeprecated-declarations]
  FlagLowDelay      Flags = C.CODEC_FLAG_LOW_DELAY
  ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from avcodec/avcodec.go:4:0:
/usr/include/ffmpeg/libavcodec/avcodec.h:5836:6: note: declared here
 void av_bitstream_filter_close(AVBitStreamFilterContext *bsf);
      ^~~~~~~~~~~~~~~~~~~~~~~~~

...

After

$ go build examples/transcoder.go
$

@codecov-io
Copy link

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   33.72%   33.72%           
=======================================
  Files           5        5           
  Lines        2583     2583           
=======================================
  Hits          871      871           
  Misses       1664     1664           
  Partials       48       48
Impacted Files Coverage Δ
avutil/avutil.go 32.91% <ø> (ø) ⬆️
avcodec/avcodec.go 22.7% <ø> (ø) ⬆️
avfilter/avfilter.go 24.83% <ø> (ø) ⬆️
avformat/avformat.go 56.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e4012...cb08b32. Read the comment docs.

@imkira
Copy link
Owner

imkira commented Jun 29, 2017

@juanvallejo Hi there. Thanks for the contribution. I was thinking, maybe it would be better to get rid of the deprecation itself, rather than just disabling the warning.

@juanvallejo
Copy link
Author

@imkira sure, will work on this once I have a bit of time

@imkira
Copy link
Owner

imkira commented Jun 30, 2017

Thanks @juanvallejo . Please let us know too which version of ffmpeg are you using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants