feat(mobile): render assets on device by default - with stream #10513
+146
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alextran1502
commented
Jun 20, 2024
alextran1502
commented
- feat(mobile): render asset on device by default
- remove unused service
- feat(mobile): render asset on device by default - with stream
alextran1502
changed the base branch from
main
to
feat/mobile/render-local-asset-by-default
alextran1502
changed the title
alextran1502
changed the base branch from
feat/mobile/render-local-asset-by-default
to
main
fyfrey
requested changes
Jun 21, 2024
| await for (final onDevice in _hashService.getHashedAssets(ape)) { | ||
| _removeDuplicates(onDevice); | ||
| // _removeDuplicates sorts `onDevice` by checksum | ||
| final (toAdd, toUpdate, toDelete) = _diffAssets(onDevice, inDb); |
There was a problem hiding this comment.
This is the issue:
You compute a diff between the entire DB and a small batch from assets on device. The diff mechanism can't work that way. You'd either need to accumulate all device assets first (loosing the stream functionality for syncing...) OR you'd need to select the appropriate portion from the DB to compare to (which is challenging to get right, but possibly!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.