fix(server): keep full datetime precision from database #10622
+120
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Breaking change, right? |
no API changes at all. |
|
Ah, the API type was already string of course. Nice :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have had these sync issues due to JavaScript reducing precision of DateTime when converting to JS Date. This still affects changes for albums, users etc. in the app and can result in not doing an update while it would be needed etc. This draft PR changes all related fields (
createdAt,updatedAt,deletedAt) in the server entities and DTOs to typestringinstead ofDate. DateTime information is passed through the JavaScript code as full precision ISO Strings.