feat(web): improve UI/UX for settings pages #12626
Conversation
…settings-accordion
alextran1502
requested review from
jrasm91,
danieldietzler,
ben-basten and
michelheusschen
alextran1502
changed the title
There was a problem hiding this comment.
This is a nice visual refresh! What do you think about moving the search bar out of the header, to spanning the width above the settings? This space is already particularly cramped in small screen sizes, and I think it would be cool to make this feature more visible and give users more space to see the text they have typed.
web/src/lib/components/shared-components/settings/setting-accordion.svelte
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben <[email protected]>
…rdion.svelte Co-authored-by: Ben <[email protected]>
web/src/lib/components/shared-components/settings/setting-accordion.svelte
Outdated
Show resolved
Hide resolved
|
|
||
| $: filteredSettings = settings.filter(({ title, subtitle }) => { | ||
| const query = searchQuery.toLowerCase(); | ||
| return title.toLowerCase().includes(query) || subtitle.toLowerCase().includes(query); |
There was a problem hiding this comment.
Can you include the actual config content on here as well? Basically index into it data.configs via the selected component.
There was a problem hiding this comment.
Can you elaborate?
There was a problem hiding this comment.
If I use Google oauth and search for "Google" would it return that result?
If I search for aac and that is the code I'm using for transcoding would it return that section as well?
I was just mentioning that you could also search against the current config for each second as well as the title and description.
This PR adds enhancements for the settings pages.
New UI
Text search