Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(server): view repository #12755

Merged
merged 1 commit into from
Sep 17, 2024
Merged

refactor(server): view repository #12755

merged 1 commit into from
Sep 17, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Sep 17, 2024

  • Move into new repository
  • Stop using getBuilder

@jrasm91 jrasm91 merged commit 1e6ef5c into main Sep 17, 2024
36 checks passed
@jrasm91 jrasm91 deleted the refactor/view-repository branch September 17, 2024 20:32
mertalev
mertalev approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the "view" naming is too generic. It doesn't really describe what the service/repository is about. FolderRepository or FolderViewRepository would be more descriptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

@mertalev mertalev mertalev approved these changes

Assignees
No one assigned
Labels
changelog:skip 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrasm91 @danieldietzler @mertalev