Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): navigation panel overlaps with right rotate #12950

Conversation

Lauritz-Tieste
Copy link
Contributor

Fix #12360

grafik

@Lauritz-Tieste Lauritz-Tieste changed the title fix(mobile): Navigation panel overlaps with right rotate fix(mobile): navigation panel overlaps with right rotate Sep 26, 2024
@Lauritz-Tieste Lauritz-Tieste changed the title fix(mobile): navigation panel overlaps with right rotate fix(mobile): navigation panel overlaps with right rotate Sep 26, 2024
@Lauritz-Tieste Lauritz-Tieste force-pushed the navigation-panel-overlap-rotate-button branch from 1415925 to 9546a73 Compare September 26, 2024 15:13
@Meliox
Copy link
Contributor

Meliox commented Sep 26, 2024

Thanks. Looking at your posted photo the checkmark and crossare not aligned with left and right rotate. Is this the intention?

@Lauritz-Tieste
Copy link
Contributor Author

Lauritz-Tieste commented Sep 26, 2024

I have experimented a little with the design. If I simply place the two buttons at the same height, the design doesn't look good because the distance to the edge of the screen is too small. I think this variant is better:

grafik
grafik

To enable a correct translation of “rotate left/right” in all languages, I would need help with the translation module

@alextran1502 alextran1502 merged commit 42ad3e6 into immich-app:main Sep 27, 2024
32 of 33 checks passed
@Lauritz-Tieste Lauritz-Tieste deleted the navigation-panel-overlap-rotate-button branch September 29, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation panel overlaps with right rotate
3 participants