Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): User removal from option menu on the top in shared album #12959

Merged
merged 18 commits into from
Oct 10, 2024
Merged

fix(web): User removal from option menu on the top in shared album #12959

merged 18 commits into from
Oct 10, 2024

Conversation

Pranav-8bit
Copy link
Contributor

In this PR, I have fixed the issue where users could not be removed from the top options menu in a shared album, as described in issue #7954

@jrasm91
Copy link
Contributor

jrasm91 commented Sep 26, 2024

Can you please stop opening and closing PRs? If this continues we will have to block your from the organization. If you need help or have a question please ask it instead.

@Pranav-8bit
Copy link
Contributor Author

Really sorry

vignesh1507
vignesh1507 reviewed Sep 28, 2024
View reviewed changes
Copy link

@vignesh1507 vignesh1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, could you add few type hints to your update code?

@Pranav-8bit
Copy link
Contributor Author

@vignesh1507 I have added a few more type hints you can check

vignesh1507
vignesh1507 reviewed Sep 28, 2024
View reviewed changes
Copy link

@vignesh1507 vignesh1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the response and for adding type hints in the code file @Pranav-8bit

@jrasm91
Copy link
Contributor

jrasm91 commented Sep 28, 2024

@vignesh1507 what are you even talking about? What is going on here?

@vignesh1507
Copy link

I asked @Pranav-8bit for adding comments/type hints in the code file which he changed and as i requested added few type hints in the code. That's what happening here @jrasm91. Hope this comment summarises the conversation in this PR.

@Pranav-8bit
Copy link
Contributor Author

Pranav-8bit commented Sep 28, 2024 •
edited
Loading

@jrasm91 Is there something wrong? I didn't get it. Is this guy not legit?

@jrasm91
Copy link
Contributor

jrasm91 commented Sep 28, 2024

They have no affiliation with the project so you can just ignore them.

@Pranav-8bit
Copy link
Contributor Author

I will push changes soon as possible

@Pranav-8bit
Copy link
Contributor Author

@martabal i have updated the code

martabal
martabal approved these changes Oct 4, 2024
View reviewed changes
web/src/lib/components/album-page/album-options.svelte Show resolved Hide resolved
web/src/lib/components/album-page/album-options.svelte Outdated
<div class="flex items-center gap-2 py-2 mt-2">
<div>
<UserAvatar {user} size="md" />
<UserAvatar user={user} size="md" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's needed

@aviv926 aviv926 mentioned this pull request Oct 5, 2024
Closed
3 tasks
Pranav-8bit and others added 3 commits October 10, 2024 11:39
@Pranav-8bit
Merge branch 'main' into fix/user-removal-from-option-menu-on-the-top…
0a83d6b 
…-in-shared-album
@alextran1502
Merge branch 'fix/user-removal-from-option-menu-on-the-top-in-shared-…
01f5e43 
…album' of https://github.com/pranav-8bit/immich; branch 'main' of github.com:immich-app/immich into fix/user-removal-from-option-menu-on-the-top-in-shared-album
@alextran1502
format fix
3d524d2
@alextran1502 alextran1502 changed the title fix(web) : User removal from option menu on the top in shared album fix(web): User removal from option menu on the top in shared album Oct 10, 2024
@alextran1502 alextran1502 enabled auto-merge (squash) October 10, 2024 08:49
@alextran1502 alextran1502 merged commit 1baa49e into immich-app:main Oct 10, 2024
33 of 34 checks passed
x24git added a commit to x24git/immich that referenced this pull request Oct 16, 2024
@x24git
Squashed commit of the following:
e9046e8 
commit edd7dfb
Author: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Oct 15 20:44:10 2024 +0000

    chore: version v1.118.1

commit 4c55597
Author: Jason Rasmussen <[email protected]>
Date:   Tue Oct 15 16:41:19 2024 -0400

    fix(server): mobile oauth login (immich-app#13474)

commit 7e49b0c
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Oct 15 15:38:18 2024 -0400

    fix(deps): update dependency tokenizers to v0.20.1 (immich-app#13470)

commit e57bd94
Author: Kevin Cox <[email protected]>
Date:   Tue Oct 15 14:53:18 2024 -0400

    chore(server): explicitly use svt-av1 encoder (immich-app#13389)

commit 8eb7980
Author: ngtrio <[email protected]>
Date:   Wed Oct 16 02:44:51 2024 +0800

    fix(docs): typo in backup-and-restore.md (immich-app#13458)

commit 0a3bfd5
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Oct 15 14:41:42 2024 -0400

    fix(deps): update dependency device_info_plus to v11 (immich-app#13427)

commit f2b799c
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Oct 15 14:39:55 2024 -0400

    chore(deps): update node (immich-app#13449)

commit 6d56927
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Oct 15 14:39:35 2024 -0400

    chore(deps): update machine-learning (immich-app#13452)

commit 8f69d9d
Author: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Oct 15 10:48:53 2024 +0000

    chore: version v1.118.0

commit 0985d7f
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Oct 14 23:24:07 2024 -0400

    chore(deps): update docker/setup-buildx-action action to v3.7.1 (immich-app#13448)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit ee50d0b
Author: Daniel Dietzler <[email protected]>
Date:   Tue Oct 15 01:18:41 2024 +0200

    chore: stack service unit tests (immich-app#13441)

commit b852468
Author: Weblate (bot) <[email protected]>
Date:   Mon Oct 14 17:16:44 2024 +0200

    chore(web): update translations (immich-app#13126)

    Translate-URL: https://hosted.weblate.org/projects/immich/immich/az/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/ca/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/cs/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/cv/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/da/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/de/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/el/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/es/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/et/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/fi/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/fr/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/he/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/hu/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/id/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/it/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/ko/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/lv/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/ms/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/nl/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/pl/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/pt/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/pt_BR/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/ro/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/ru/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/sk/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/sr_Cyrl/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/sr_Latn/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/sv/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/tr/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/uk/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/vi/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/zh_Hant/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/zh_SIMPLIFIED/
    Translation: Immich/immich

    Co-authored-by: -J- <[email protected]>
    Co-authored-by: Ahmad Eri Syafrizal bin Syamaial Huda <[email protected]>
    Co-authored-by: Ben Tomsen <[email protected]>
    Co-authored-by: Bezruchenko Simon <[email protected]>
    Co-authored-by: CanbiZ <[email protected]>
    Co-authored-by: CrossDrain <[email protected]>
    Co-authored-by: David S <[email protected]>
    Co-authored-by: Dorin Rusu <[email protected]>
    Co-authored-by: Emre Saraçoğlu <[email protected]>
    Co-authored-by: Enoé Mugnaschi <[email protected]>
    Co-authored-by: Erman Yaman <[email protected]>
    Co-authored-by: Fjuro <[email protected]>
    Co-authored-by: Florian Ostertag <[email protected]>
    Co-authored-by: Furkan Aydın <[email protected]>
    Co-authored-by: Henrik <[email protected]>
    Co-authored-by: Hurricane-32 <[email protected]>
    Co-authored-by: Indrek Haav <[email protected]>
    Co-authored-by: Jacek <[email protected]>
    Co-authored-by: Jamil Farajov <[email protected]>
    Co-authored-by: Jonne Saloranta <[email protected]>
    Co-authored-by: Juan <[email protected]>
    Co-authored-by: Junghyuk Kwon <[email protected]>
    Co-authored-by: Leo Bottaro <[email protected]>
    Co-authored-by: LeonardoCasarotto <[email protected]>
    Co-authored-by: Linerly <[email protected]>
    Co-authored-by: Marius Redean <[email protected]>
    Co-authored-by: Michel Heusschen <[email protected]>
    Co-authored-by: Miki Mrvos <[email protected]>
    Co-authored-by: Mārtiņš Bruņenieks <[email protected]>
    Co-authored-by: Nick Renieris <[email protected]>
    Co-authored-by: Rookie Nguyễn <[email protected]>
    Co-authored-by: Simone D'Anna <[email protected]>
    Co-authored-by: Stan P <[email protected]>
    Co-authored-by: Sylvain Pichon <[email protected]>
    Co-authored-by: Thomas Möller <[email protected]>
    Co-authored-by: Xo <[email protected]>
    Co-authored-by: bill85101 <[email protected]>
    Co-authored-by: chapvic <[email protected]>
    Co-authored-by: coolstuff99 <[email protected]>
    Co-authored-by: dvbthien <[email protected]>
    Co-authored-by: extremq <[email protected]>
    Co-authored-by: gallegonovato <[email protected]>
    Co-authored-by: pyccl <[email protected]>
    Co-authored-by: pyorot <[email protected]>
    Co-authored-by: qtm <[email protected]>
    Co-authored-by: samk <[email protected]>
    Co-authored-by: tomtom <[email protected]>
    Co-authored-by: waclaw66 <[email protected]>
    Co-authored-by: Вячеслав Лукьяненко <[email protected]>
    Co-authored-by: Мĕтри Сантăр ывалĕ Упа-Миччи <[email protected]>
    Co-authored-by: 전경재 <[email protected]>

commit 22a2bfc
Author: Alex <[email protected]>
Date:   Mon Oct 14 22:06:24 2024 +0700

    chore(mobile): Translations update (immich-app#13423)

    chore(mobile): translation update

commit 7a78c33
Author: Jason Rasmussen <[email protected]>
Date:   Mon Oct 14 10:20:10 2024 -0400

    chore: add deprecated release notes section (immich-app#13435)

commit 452ce73
Author: Alex <[email protected]>
Date:   Mon Oct 14 15:52:58 2024 +0700

    fix(mobile): more efficient loading local image on ios (immich-app#13426)

commit 346a084
Author: Alex <[email protected]>
Date:   Mon Oct 14 11:40:46 2024 +0700

    fix(server): REVERT incorrect out_color_matrix value when generating thumbnails (immich-app#13409) (immich-app#13424)

    Revert "fix(server): incorrect out_color_matrix value when generating thumbnails (immich-app#13409)"

    This reverts commit 9bdfb41.

commit f59b813
Author: Alex <[email protected]>
Date:   Mon Oct 14 09:50:07 2024 +0700

    chore(mobile): search page minor enhancements (immich-app#13403)

    * chore(mobile): search page retouched

    * add placeholder photos

    * remove unused page

    * focus the search input when tapping on the search controller button

    * detail fixed

    * remove print statements

    * disable scrolling of empty content

commit 1193adf
Author: fa1seut0pia <[email protected]>
Date:   Mon Oct 14 09:23:20 2024 +0800

    fix(web): change the code zh-Hans to zh-CN (immich-app#13414)

    fix/(web) change the code zh-Hans to zh-CN

commit e7397f3
Author: Mert <[email protected]>
Date:   Sun Oct 13 18:00:21 2024 -0400

    chore(ml): update pydantic (immich-app#13230)

    * update pydantic

    * fix typing

    * remove unused import

    * remove unused schema

commit f29fb16
Author: martin <[email protected]>
Date:   Sun Oct 13 21:34:38 2024 +0200

    docs: update authelia link (immich-app#13413)

commit 9bdfb41
Author: lyyn <[email protected]>
Date:   Sun Oct 13 19:19:40 2024 +0200

    fix(server): incorrect out_color_matrix value when generating thumbnails (immich-app#13409)

commit 5a3e352
Author: Alex <[email protected]>
Date:   Mon Oct 14 00:10:52 2024 +0700

    fix(server): typeorm (੭ °ཀ°)੭ (immich-app#13411)

commit e183ff6
Author: bo0tzz <[email protected]>
Date:   Sun Oct 13 15:08:40 2024 +0200

    feat: log SOURCE_REF immediately in container startup (immich-app#13405)

    This change makes sure the ref should be in pretty much any log we might get sent, making it easier to catch people running the wrong version.

commit 20b4d28
Author: Daniel Dietzler <[email protected]>
Date:   Sat Oct 12 03:33:10 2024 +0200

    chore: media service unit tests (immich-app#13382)

commit 0b48d46
Author: Jonathan Jogenfors <[email protected]>
Date:   Fri Oct 11 20:51:46 2024 +0200

    chore: Add viteconfig-timestamp to .gitignore (immich-app#13380)

commit 3b7bf76
Author: Daniel Dietzler <[email protected]>
Date:   Fri Oct 11 20:40:29 2024 +0200

    chore: library unit tests (immich-app#13357)

commit 930df46
Author: Jason Rasmussen <[email protected]>
Date:   Fri Oct 11 00:44:38 2024 -0400

    chore(server): remove unused code (immich-app#13367)

commit 8daa807
Author: Jason Rasmussen <[email protected]>
Date:   Thu Oct 10 11:53:53 2024 -0400

    refactor(server): add base methods for access checks (immich-app#13349)

commit 97edf90
Author: Daniel Dietzler <[email protected]>
Date:   Thu Oct 10 17:51:54 2024 +0200

    fix: library deletion (immich-app#13350)

commit 24e266c
Author: Zack Pollard <[email protected]>
Date:   Thu Oct 10 15:45:50 2024 +0100

    ci: don't auto-update mapbox-gl-rtl-text (immich-app#13351)

commit 79ae4e2
Author: Daniel Dietzler <[email protected]>
Date:   Thu Oct 10 15:07:37 2024 +0200

    chore: database service unit tests (immich-app#13345)

commit bd779ff
Author: Daniel Dietzler <[email protected]>
Date:   Thu Oct 10 15:04:44 2024 +0200

    chore: cli unit tests (immich-app#13343)

commit 94048de
Author: Zack Pollard <[email protected]>
Date:   Thu Oct 10 12:16:37 2024 +0100

    fix(web): rtl text on map is hidden (immich-app#13342)

commit ee461e5
Author: Alex <[email protected]>
Date:   Thu Oct 10 16:53:33 2024 +0700

    chore(mobile): remove unused translation keys (immich-app#13335)

commit 4ce49e4
Author: Alex <[email protected]>
Date:   Thu Oct 10 16:53:20 2024 +0700

    chore(mobile): clean up (immich-app#13338)

commit 1baa49e
Author: Pranav tiwari <[email protected]>
Date:   Thu Oct 10 14:26:08 2024 +0530

    fix(web): User removal from option menu on the top in shared album (immich-app#12959)

    * bug fix

    * added few more type hint

    * onMount removed, removed current user to user

    * user check removed and conflict in view mode resolved between option and share info modal

    * format fix

    ---------

    Co-authored-by: Alex <[email protected]>

commit 53358c7
Author: Yashraj Jain <[email protected]>
Date:   Thu Oct 10 14:22:12 2024 +0530

    fix(mobile): trash sorting order (immich-app#13299)

    * fix: trash sorting order

    * updated after comparing with web

commit e981331
Author: Alex <[email protected]>
Date:   Thu Oct 10 15:44:14 2024 +0700

    feat(mobile): new mobile UI (immich-app#12582)

commit b59abdf
Author: Jonathan Jogenfors <[email protected]>
Date:   Thu Oct 10 10:42:59 2024 +0200

    chore(e2e): dont check for immich folder (immich-app#13298)

    chore: dont check immich folder

commit 465f463
Author: Jason Rasmussen <[email protected]>
Date:   Wed Oct 9 16:01:52 2024 -0400

    feat: align compose ports (immich-app#13185)

commit b7dcc97
Author: Jonathan Jogenfors <[email protected]>
Date:   Wed Oct 9 18:15:50 2024 +0200

    fix(cli): allow special characters in paths (immich-app#13282)

    * fix(cli): commas in import paths

    * adding more test cases

commit 057510a
Author: rgomulin <[email protected]>
Date:   Wed Oct 9 19:06:16 2024 +0300

    chore(mobile): added 'ignore_icloud' translation item (immich-app#12788)

    impr: added 'ignore_icloud' translation item

commit 7561d41
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Oct 9 16:05:34 2024 +0000

    chore(deps): bump docker/setup-buildx-action from 3.6.1 to 3.7.0 (immich-app#13148)

    Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.6.1 to 3.7.0.
    - [Release notes](https://github.com/docker/setup-buildx-action/releases)
    - [Commits](docker/setup-buildx-action@v3.6.1...v3.7.0)

    ---
    updated-dependencies:
    - dependency-name: docker/setup-buildx-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 360e7d6
Author: Max <[email protected]>
Date:   Wed Oct 9 18:04:13 2024 +0200

    docs: fix typo in Backup Script Guide (immich-app#12399)

commit e1540c8
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Oct 9 22:59:24 2024 +0700

    chore(deps): bump rexml from 3.2.8 to 3.3.6 in /mobile/ios (immich-app#12621)

    Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.6.
    - [Release notes](https://github.com/ruby/rexml/releases)
    - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
    - [Commits](ruby/rexml@v3.2.8...v3.3.6)

    ---
    updated-dependencies:
    - dependency-name: rexml
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 1a72602
Author: Joren Guillaume <[email protected]>
Date:   Wed Oct 9 17:37:47 2024 +0200

    docs: Add DB name to backup-and-restore (immich-app#13244)

    * Update backup-and-restore.md

    changelog:
    Add database name to the restore command and document it in the notes

    * docs: remove added database flag and change warn wording

    * docs: fix forgotten warning change

    Co-authored-by: Matthew Momjian <[email protected]>

    ---------

    Co-authored-by: Matthew Momjian <[email protected]>

commit f7ad6ef
Author: Jason Rasmussen <[email protected]>
Date:   Wed Oct 9 10:00:40 2024 -0400

    feat(server): medium tests (immich-app#13289)

commit 27c04f9
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Oct 9 11:32:18 2024 +0100

    chore(deps): update typescript-projects (immich-app#13293)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 4780bb4
Author: itoktsnhc <[email protected]>
Date:   Wed Oct 9 12:21:31 2024 +0800

    fix(server): fix server ping URL path mismatch in healthcheck.ts (immich-app#13297)

    fix server ping URL path mismatch in healthcheck.ts

commit 3ba2602
Author: Mert <[email protected]>
Date:   Tue Oct 8 18:03:28 2024 -0400

    fix(ml): pin onnxruntime-openvino (immich-app#13290)

commit 08d428c
Author: Mert <[email protected]>
Date:   Tue Oct 8 17:37:41 2024 -0400

    fix(server): duplicate faces, face insert query failing (immich-app#13294)

    fix duplicate faces, query failing

commit 9d0f038
Author: Daniel Dietzler <[email protected]>
Date:   Tue Oct 8 23:08:49 2024 +0200

    chore: finishing unit tests for a couple of services (immich-app#13292)

commit f5e0cde
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Oct 8 15:27:47 2024 -0400

    chore(deps): update redis:6.2-alpine docker digest to 2ba50e1 (immich-app#13266)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 9a6fd1c
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Oct 8 15:27:27 2024 -0400

    chore(deps): update docker.io/redis:6.2-alpine docker digest to 2ba50e1 (immich-app#13265)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit bff3690
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Oct 8 15:26:53 2024 -0400

    chore(deps): update docker/setup-buildx-action action to v3.7.0 (immich-app#13281)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit d2800a6
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Oct 8 15:22:04 2024 -0400

    chore(deps): update base-image to v20241008 (major) (immich-app#13284)

    chore(deps): update base-image to v20241008

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit d47def4
Author: Jason Rasmussen <[email protected]>
Date:   Tue Oct 8 12:10:52 2024 -0400

    fix(server): timezones (immich-app#13262)

commit 34305b2
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Oct 8 12:37:55 2024 +0200

    chore(deps): update dependency @types/lodash to v4.17.10 (immich-app#13280)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit a11d454
Author: Alex <[email protected]>
Date:   Tue Oct 8 11:42:19 2024 +0700

    fix(web): video player on Safari (immich-app#13242)

commit 60e0698
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Oct 7 22:44:28 2024 -0400

    chore(deps): update typescript-projects (immich-app#13272)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 48c6c1a
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Oct 7 22:42:33 2024 -0400

    chore(deps): update dependency node to v20.18.0 (immich-app#13271)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 58f14f2
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Oct 7 22:11:57 2024 -0400

    fix(deps): update machine-learning (immich-app#13270)

commit 680bf34
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Oct 8 02:05:31 2024 +0000

    chore(deps): update dependency @types/node to ^20.16.10 (immich-app#13269)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit bd826b0
Author: Mert <[email protected]>
Date:   Mon Oct 7 17:37:45 2024 -0400

    feat(ml): round-robin device assignment (immich-app#13237)

    * round-robin device assignment

    * docs and tests

    clarify doc

commit 063969c
Author: Mert <[email protected]>
Date:   Mon Oct 7 15:44:04 2024 -0400

    fix(server): searching with both `personIds` and `withPeople` (immich-app#13254)

    * use cte

    * linting

commit 5b00bc4
Author: Jonathan Jogenfors <[email protected]>
Date:   Mon Oct 7 21:43:21 2024 +0200

    fix(server): Allow commas and braces in import paths (immich-app#13259)

    fix commas and braces in paths

commit 94d213b
Author: Zack Pollard <[email protected]>
Date:   Mon Oct 7 14:34:48 2024 +0100

    fix(server): external libraries queueing two transcode jobs (immich-app#13251)

commit 1b62c99
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Oct 7 12:34:45 2024 +0100

    chore(deps): update grafana/grafana docker tag to v11.2.2 (immich-app#13235)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    Co-authored-by: Zack Pollard <[email protected]>

commit b4bf1bb
Author: Zack Pollard <[email protected]>
Date:   Mon Oct 7 11:42:04 2024 +0100

    feat: support and feedback modal with third party support (immich-app#13248)

commit 6f86c2f
Author: Alex <[email protected]>
Date:   Mon Oct 7 08:45:23 2024 +0700

    chore(mobile): use sdk to for ping endpoint (immich-app#13218)

commit 4bb42c4
Author: Mert <[email protected]>
Date:   Sun Oct 6 13:16:31 2024 -0400

    docs: update version range for pgvecto.rs (immich-app#13231)

    * update pgvecto.rs range

    * clarify pg17

commit a8d16fe
Author: Yoni Yang <[email protected]>
Date:   Sun Oct 6 22:17:59 2024 +0800

    docs: fix confustion about libmali in hardware-transcoding.md  (immich-app#13226)

commit 52c700e
Author: Yuvraj P <[email protected]>
Date:   Sun Oct 6 02:51:11 2024 -0400

    feat(mobile): Adding filters feature to mobile image editor (immich-app#13174)

    * Adding filters button

    * Filter selection page

    * routing

    * Localization

    * Add Filters to this page

    * More Filters yay!

    * Final filters

    * Logic for saving the image

    * Fixes

    * Formmating

    * Finalizing, formating, and fixes

    * Layout fix

    * chores

    * Chore: Static code analysis

    * fix translation file

    ---------

    Co-authored-by: Alex <[email protected]>

commit c5c492e
Author: aviv926 <[email protected]>
Date:   Sun Oct 6 02:00:09 2024 +0300

    feat(docs): update roadmap (immich-app#13212)

    * feat(docs): update roadmap

    * PR feedback

    * PR feedabck

commit a5e9adb
Author: Daniel Dietzler <[email protected]>
Date:   Sat Oct 5 22:37:33 2024 +0200

    chore: migrate oauth to repo (immich-app#13211)

commit 9d9bf1c
Author: Daniel Dietzler <[email protected]>
Date:   Sat Oct 5 18:16:23 2024 +0200

    chore: auth unit tests (immich-app#13207)

commit 0f3b8b6
Author: Fynn Petersen-Frey <[email protected]>
Date:   Sat Oct 5 03:02:34 2024 +0200

    refactor(mobile): assert lists are sorted for diffing (immich-app#13180)

commit 6bbaba7
Author: Jason Rasmussen <[email protected]>
Date:   Fri Oct 4 17:09:02 2024 -0400

    refactor(server): resource paths (immich-app#13194)

commit 5d0a4bb
Author: Jason Rasmussen <[email protected]>
Date:   Fri Oct 4 16:57:34 2024 -0400

    refactor(server): app module (immich-app#13193)

commit 7ee0221
Author: Jason Rasmussen <[email protected]>
Date:   Fri Oct 4 15:10:13 2024 -0400

    chore: remove deprecated endpoint (immich-app#13190)

commit 08db817
Author: Jason Rasmussen <[email protected]>
Date:   Fri Oct 4 15:10:03 2024 -0400

    chore: remove deprecated controller (immich-app#13189)

commit dc18731
Author: Daniel Dietzler <[email protected]>
Date:   Fri Oct 4 20:04:37 2024 +0200

    chore: audit service unit tests (immich-app#13183)

commit 4adedea
Author: Daniel Dietzler <[email protected]>
Date:   Fri Oct 4 19:37:18 2024 +0200

    chore: asset service unit tests (immich-app#13179)

commit bb3b4c8
Author: Carsten Otto <[email protected]>
Date:   Fri Oct 4 10:30:49 2024 +0200

    fix(server): update exiftool-vendored to v28.3.1 (immich-app#13176)

    fixes immich-app#13141

commit 2c87683
Author: Mert <[email protected]>
Date:   Thu Oct 3 21:58:28 2024 -0400

    feat(server): refresh face detection (immich-app#12335)

    * refresh faces

    handle non-ml faces

    * fix metadata face handling

    * updated tests

    * added todo comment

commit 9edc9d6
Author: Jason Rasmussen <[email protected]>
Date:   Thu Oct 3 17:49:03 2024 -0400

    refactor(server): immich app env (immich-app#13169)

commit 3ac00b0
Author: Jason Rasmussen <[email protected]>
Date:   Thu Oct 3 17:48:40 2024 -0400

    refactor(server): db env (immich-app#13167)

commit e2bf680
Author: Jason Rasmussen <[email protected]>
Date:   Thu Oct 3 16:58:15 2024 -0400

    refactor(server): no color env (immich-app#13166)

commit 0eb7714
Author: Jason Rasmussen <[email protected]>
Date:   Thu Oct 3 16:33:43 2024 -0400

    refactor(server): build support env (immich-app#13163)

commit 3ddb5b8
Author: Jason Rasmussen <[email protected]>
Date:   Thu Oct 3 15:45:37 2024 -0400

    refactor(server): license key env (immich-app#13162)

commit 2c8c365
Author: Daniel Dietzler <[email protected]>
Date:   Thu Oct 3 21:36:54 2024 +0200

    chore: some more unit tests :) (immich-app#13159)

commit db1623f
Author: Jason Rasmussen <[email protected]>
Date:   Thu Oct 3 15:28:36 2024 -0400

    refactor(server): worker env (immich-app#13160)

commit 892a35a
Author: Jason Rasmussen <[email protected]>
Date:   Thu Oct 3 13:29:40 2024 -0400

    refactor(server): port env (immich-app#13158)

commit bf43c32
Author: bo0tzz <[email protected]>
Date:   Thu Oct 3 14:10:50 2024 +0200

    chore: disable dependabot (immich-app#13150)

commit 68930cc
Author: Alex <[email protected]>
Date:   Thu Oct 3 13:33:36 2024 +0700

    feat(doc): new homepage design and font (immich-app#13084)

commit 0454863
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Oct 3 03:57:50 2024 +0000

    fix(deps): update dependency connectivity_plus to v6 (immich-app#13115)

    * fix(deps): update dependency connectivity_plus to v6

    * update api

    ---------

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    Co-authored-by: Alex <[email protected]>

commit 432bcbb
Author: Alex <[email protected]>
Date:   Thu Oct 3 10:19:14 2024 +0700

    chore(mobile): post release task (immich-app#13136)

commit 1700de9
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Oct 3 10:16:59 2024 +0700

    fix(deps): update dependency device_info_plus to v10 (immich-app#13117)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 35bb2e7
Author: Hannes R. Brunsch <[email protected]>
Date:   Thu Oct 3 03:02:38 2024 +0000

    fix(mobile): respect orientation on displaying asset dimensions (immich-app#13129)

    * fix(mobile): respect orientation on displaying asset dimensions

    * lint

    ---------

    Co-authored-by: Alex <[email protected]>

commit 31c0dfb
Author: martin <[email protected]>
Date:   Thu Oct 3 04:30:26 2024 +0200

    fix: preloading fonts (immich-app#13132)

commit 6b84624
Author: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Thu Oct 3 01:59:28 2024 +0000

    chore: version v1.117.0

commit 9821b46
Author: Daniel Dietzler <[email protected]>
Date:   Wed Oct 2 23:28:13 2024 +0200

    chore: add more languages (immich-app#13127)

commit 8ee8259
Author: Mert <[email protected]>
Date:   Wed Oct 2 16:53:17 2024 -0400

    fix(server): thumbnail colorspace handling (immich-app#13130)

    fix colorspace handling

commit 355ed5b
Author: Weblate (bot) <[email protected]>
Date:   Wed Oct 2 19:14:50 2024 +0200

    chore(web): update translations (immich-app#12938)

    Translate-URL: https://hosted.weblate.org/projects/immich/immich/ar/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/az/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/bg/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/ca/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/cs/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/de/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/el/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/es/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/et/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/fr/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/he/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/hu/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/it/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/ko/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/lv/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/ms/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/nl/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/pl/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/pt/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/ru/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/sr_Cyrl/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/sr_Latn/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/tr/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/uk/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/vi/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/zh_Hant/
    Translate-URL: https://hosted.weblate.org/projects/immich/immich/zh_SIMPLIFIED/
    Translation: Immich/immich

    Co-authored-by: -J- <[email protected]>
    Co-authored-by: Alexis Rossfelder <[email protected]>
    Co-authored-by: Bezruchenko Simon <[email protected]>
    Co-authored-by: Damian Krysta <[email protected]>
    Co-authored-by: David S <[email protected]>
    Co-authored-by: Denis Pacquier <[email protected]>
    Co-authored-by: Emre Saraçoğlu <[email protected]>
    Co-authored-by: Fjuro <[email protected]>
    Co-authored-by: Florian Ostertag <[email protected]>
    Co-authored-by: Hurricane-32 <[email protected]>
    Co-authored-by: Indrek Haav <[email protected]>
    Co-authored-by: Ioannis Ioannou <[email protected]>
    Co-authored-by: Jacek <[email protected]>
    Co-authored-by: Jamil Farajov <[email protected]>
    Co-authored-by: Joachim Segala <[email protected]>
    Co-authored-by: Jordi Masip <[email protected]>
    Co-authored-by: JoseFilipeFerreira <[email protected]>
    Co-authored-by: Julien Deveaux <[email protected]>
    Co-authored-by: Junghyuk Kwon <[email protected]>
    Co-authored-by: Lauritz Tieste <[email protected]>
    Co-authored-by: LeonardoCasarotto <[email protected]>
    Co-authored-by: Manar Aldroubi <[email protected]>
    Co-authored-by: Michel Heusschen <[email protected]>
    Co-authored-by: Miki Mrvos <[email protected]>
    Co-authored-by: Mārtiņš Bruņenieks <[email protected]>
    Co-authored-by: Ognian Samokovliyski <[email protected]>
    Co-authored-by: Shawn <[email protected]>
    Co-authored-by: Unn Krigul <[email protected]>
    Co-authored-by: V R <[email protected]>
    Co-authored-by: chapvic <[email protected]>
    Co-authored-by: clementdelestre <[email protected]>
    Co-authored-by: dvbthien <[email protected]>
    Co-authored-by: eav5jhl0 <[email protected]>
    Co-authored-by: faizfahmi-dev <[email protected]>
    Co-authored-by: gallegonovato <[email protected]>
    Co-authored-by: kiwinho <[email protected]>
    Co-authored-by: pyccl <[email protected]>
    Co-authored-by: pyorot <[email protected]>
    Co-authored-by: ti777777 <[email protected]>
    Co-authored-by: waclaw66 <[email protected]>
    Co-authored-by: Вячеслав Лукьяненко <[email protected]>
    Co-authored-by: 李奕寯 <[email protected]>

commit 3c9413f
Author: Alex <[email protected]>
Date:   Thu Oct 3 00:04:22 2024 +0700

    chore(web): relax spacing for help and feedback modal (immich-app#13118)

commit 681b06a
Author: Ben McCann <[email protected]>
Date:   Wed Oct 2 09:36:06 2024 -0700

    fix(docs): fix broken image URL (immich-app#13122)

commit e7862fc
Author: martin <[email protected]>
Date:   Wed Oct 2 17:04:21 2024 +0200

    fix: mouse hover over stack (immich-app#13119)

    fix: mouse hover on stack

commit 4ea281f
Author: Jason Rasmussen <[email protected]>
Date:   Wed Oct 2 10:54:35 2024 -0400

    refactor: service dependencies (immich-app#13108)

    refactor(server): simplify service dependency management

commit 1b7e4b4
Author: PetrSvirak <[email protected]>
Date:   Wed Oct 2 15:39:14 2024 +0200

    fix(docs): Update TrueNAS installation docs (immich-app#13017)

    Mention about ACL mode added for the case when library is located in a dataset with network sharing capabilities.

    Based on [community issue](https://www.truenas.com/community/threads/immich-app-permissions-to-copy-to-path-inside-smb-share.117253/) and [redit post](https://www.reddit.com/r/truenas/comments/1b1weo9/comment/l132fuj/)
yosit pushed a commit to yosit/immich that referenced this pull request Oct 16, 2024
@Pranav-8bit @alextran1502
fix(web): User removal from option menu on the top in shared album (i…
dc521f4 
…mmich-app#12959)

* bug fix

* added few more type hint

* onMount removed, removed current user to user

* user check removed and conflict in view mode resolved between option and share info modal

* format fix

---------

Co-authored-by: Alex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vignesh1507 vignesh1507 vignesh1507 left review comments

@bo0tzz bo0tzz bo0tzz left review comments

@martabal martabal martabal approved these changes

Assignees
No one assigned
Labels
changelog:bugfix 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pranav-8bit @jrasm91 @vignesh1507 @bo0tzz @martabal @alextran1502