fix(mobile): incorrect filename is retrieved during upload #12990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo0tzz
approved these changes
Sep 27, 2024
| String originalFileName = asset.fileName; | ||
| String? originalFileName = | ||
| await _assetMediaRepository.getOriginalFilename(asset.localId!); | ||
| originalFileName ??= asset.fileName; |
There was a problem hiding this comment.
This fallback should maybe be inside the func above?
Is this syntax common in the mobile codebase? I find it really confusing lol.
There was a problem hiding this comment.
Yeah, if null, assign the value, otherwise keep the current value.
Inside the function, the AssetEntity can be null, so there is no property to get the other filename from
danieldietzler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.