Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update nginx example config #13016

Closed
wants to merge 1 commit into from

Conversation

PetrSvirak
Copy link
Contributor

This tweak in the nginx example should make all requests made by immich web app go through the SSL.

I stumbled upon the lack of the header when setting up nginx to redirect wan traffic to an immich instance and noticed a lot of tracking still wanting to use HTTP instead of HTTPS protocol.

I was unsure how to file an improvement for docs properly, so I created this PR instead. Please, if this change is too niche (not universal enough in your eyes) or requires an unnecessary amount of effort on your side to merge, feel free to close the PR.

This tweak in nginx example should make all
request made by immich web app go through SSL
by default, not requiring other ports than 443
opened to outboud connections.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 28, 2024
@bo0tzz
Copy link
Member

bo0tzz commented Sep 28, 2024

This is generally a sensible thing to do, but I'm not sure how I feel about it here since we deliberately keep these configs as minimal as possible and it doesn't have any HTTPS config for that reason.

@PetrSvirak
Copy link
Contributor Author

PetrSvirak commented Sep 28, 2024

Thanks for the quick reaction. I will only add that I did not know how or whether to update Caddy, Apache, and Traefik in a similar fashion - that might be a thing missing in this PR even if changing nginx would look like a good idea.

The reason I created this PR anyway was that the TLS was basically the only reason I set up a reverse proxy for my instance. But I might be side-tracking a bit: So let's close this PR?

@jrasm91
Copy link
Contributor

jrasm91 commented Oct 1, 2024

While useful, it is a bit out of scope for immich itself so I will go ahead and close this.

@jrasm91 jrasm91 closed this Oct 1, 2024
@PetrSvirak PetrSvirak deleted the update_xginx_docs branch October 2, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants