fix(server): "all" button for facial recognition deleting faces instead of unassigning them #13042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
approved these changes
Sep 30, 2024
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Oct 3, 2024
…ad of unassigning them (immich-app#13042) * unassign faces instead of deleting them * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This button is intended to recluster faces based on the current facial recognition settings. However, it currently deletes these faces, requiring the user to run face detection again unnecessarily.
Fixes #12454
Fixes #12769
Fixes #12691
How Has This Been Tested?
Tested that it doesn't delete faces and reclusters them as expected.