chore: move library settings cron expression to setting select element #13856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the motivation of this change? I think you should still be able to set the cron to something besides one of the presets. Oh, never mind. I thought this was removing the text field. |
I was in the middle of replying 😆 |
mertalev
approved these changes
Oct 31, 2024
mertalev
reviewed
Oct 31, 2024
web/src/lib/components/admin-page/settings/library-settings/library-settings.svelte
Outdated
Show resolved
Hide resolved
zackpollard
force-pushed
the
chore/library-select-element
branch
from
d59da99
to
b0f53f6
Compare
TimVanOnckelen
pushed a commit
to TimVanOnckelen/immich
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.