Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): timeline bucketing by day #9935

Closed
wants to merge 4 commits into from

Conversation

alextran1502
Copy link
Contributor

This PR solves the issues of bucket render of a month can make the browser crash if a certain month has more than 4000 or 5000 assets by rendering the bucket by day grouping.

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test this?

@alextran1502
Copy link
Contributor Author

alextran1502 commented Jun 2, 2024 via email

@jrasm91
Copy link
Contributor

jrasm91 commented Jun 2, 2024

Nice. I was more wondering if you tested with different bucket sizes and distributions.

@alextran1502
Copy link
Contributor Author

alextran1502 commented Jun 2, 2024 via email

Copy link
Contributor

@michelheusschen michelheusschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function still assumes buckets by month and that'll probably cause issues when uploading assets

const timeBucket = DateTime.fromISO(asset.fileCreatedAt).toUTC().startOf('month').toString();

@alextran1502 alextran1502 marked this pull request as draft June 3, 2024 21:11
@mehmooda
Copy link

should it be using localDateTime rather than fileCreatedAt? In some of my external libraries the fileCreatedAt time is the time the backup was taken and not the date the image was taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants