transpile: operators: resolve type when checking for unsignedness #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fw-immunant
force-pushed
the
fw/resolve-unsignedness
branch
from
acf1ab5 to
7349f95
Compare
Really happy to see you were able to track down the underlying issue of the regression. Great job @fw-immunant! |
|
From CI it looks like macOS produces syntactically different output; this is blocked on #1270 if we want the test coverage. |
this isn't how we want this code to be transpiled (it should use `wrapping_mul`), but it is how it transpiles now
other code in operators.rs remembers to do this, but this method forgot fixes #1024
fw-immunant
force-pushed
the
fw/resolve-unsignedness
branch
from
7349f95 to
d594f26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1024. Thanks to @mewmew for their patience and the pre-reduced test case!