transpile: const macros: skip fn ptr types, as they don't work with portable types #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ortable types The workaround for non-portable types for const macros is to insert a use-site cast to the portable type, but this works differently for fn ptrs, so while #1321 is fixed, just skip fn ptr const macros. This should get #1384 to pass CI by working around this issue there, and it should also workaround #1366, although #1366 in `libxml2` appears to have been fixed/worked around from some other change, as #1385 now passes CI.
kkysen
force-pushed
the
kkysen/const-macros-skip-fn-ptrs
branch
from
8979d07 to
8b47edc
Compare
|
I don't think this commit alters the behavior of the |
kkysen
commented
Oct 3, 2025
I think the motivation behind this is still sound, but a test case for this would need to involve function pointer types without mentioning any decls, which is probably tricky while avoiding casts that are forbidden during const execution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround for non-portable types for const macros is to insert a use-site cast to the portable type, but this works differently for fn ptrs, so while #1321 is fixed, just skip fn ptr const macros.
This should get #1384 to pass CI by working around this issue there, and it should also workaround #1366, although #1366 in
libxml2appears to have been fixed/worked around from some other change, as #1385 now passes CI.