Fix z3 in CI for restored c2rust-refactor

[fw-immunant]

I think this requires less fiddly setup with newer versions of the z3 crate, but we can't use those because they switch to the 2024 edition, which our pinned nightly from 2023 doesn't know about.

[ahomescu]

Don't we also have a problem on mac OS? I couldn't figure out how to solve that one.

[ahomescu]

Couldn't this have been a pull request from #1328, so it only shows your new commits?

[ahomescu]

Couldn't this have been a pull request from #1328, so it only shows your new commits?

I mean, I can cherry-pick your fixes once they work, but PR-against-PR might have been cleaner.

[fw-immunant]

Couldn't this have been a pull request from #1328, so it only shows your new commits?

I mean, I can cherry-pick your fixes once they work, but PR-against-PR might have been cleaner.

I just opened a PR to run CI; I can set target to your branch if you want. I wasn't sure if this would need a rebase/etc. first and wanted to avoid noise in the original PR, or I would have just pushed to that branch.

[ahomescu]

Couldn't this have been a pull request from #1328, so it only shows your new commits?

I mean, I can cherry-pick your fixes once they work, but PR-against-PR might have been cleaner.

I just opened a PR to run CI; I can set target to your branch if you want. I wasn't sure if this would need a rebase/etc. first and wanted to avoid noise in the original PR, or I would have just pushed to that branch.

Just nitpicking and trying to make our lives easier, appreciate the help! I'm not sure when I'll get around to rebase my original branch, but I could roll your fixes into it once they pass CI.

[fw-immunant]

I'm not sure when I'll get around to rebase my original branch, but I could roll your fixes into it once they pass CI.

Despite GH's claims to the contrary, a simple git rebase master seems to work without any intervention locally.

[fw-immunant]

macOS CI now works... but for some reason the testsuite is broken.

[fw-immunant]

e2fbf8c failed the z3 test claiming quickcheck failed:

---- transform::casts::tests::verify_double_cast stdout ----
thread 'transform::casts::tests::verify_double_cast' panicked at '[quickcheck] TEST FAILED. Arguments: (PointerWidth(64), [Int(32, true), Int(32, false), Size(true)])', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/quickcheck-0.9.2/src/tester.rs:178:28
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Upon further investigation, it looks like this is a real test failure, but not macOS-related. That CI run just got lucky with quickcheck seeds. I'll submit a follow-up PR.