Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #include <iostream> to allow compiling for small embedded systems #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove #include <iostream> to allow compiling for small embedded systems #61

wants to merge 2 commits into from
+1 −6

Commits on May 26, 2020

  1. Remove unneeded headers to keep iostream from pulling in 10^5 bytes 

    Admittedly it's a bit brute force to just remove the header inclusions, and that it works is based on all the iostream -related code being in templates, so that when they're not used there's no problem. Of you do use them, you have to include <iostream> yourself (and I'm not 100% sure that there won't be restrictions in order of includes).

Another approach, maybe more robust but less elegant, would be to #ifdef out the iostream headers if some flag (PCG_DONOTUSEIOSTREAM ? ) is defined

Removing <new> is not absolutely necessary, but I'm not sure what it's used for here, the only relevant part I could find is one use of placement new?
    Timo Alho committed May 26, 2020
    Configuration menu
    Copy the full SHA
    a7fdb16 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    Timo Alho committed May 26, 2020
    Configuration menu
    Copy the full SHA
    7ad3b1c View commit details
    Browse the repository at this point in the history