Track updates to relationships #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Track updates to relationships in all related tables by adding a new field `relationship_updated_at` to all principal tables (see below) that is updated with the current date anytime a change happens to a relationship (create/update/delete) Specifically the principal tables are (with join tables nested) - [x] measures - [x] measure_categories - [x] measure_indicators - [x] indicators - [x] measure_indicators - [x] users - [x] user_roles - [x] user_categories
We want to call the `last_modified_user_id` field `updated_by_id` instead.
We want to record who created each record.
tmfrnz
approved these changes
Feb 19, 2024
| @@ -12,6 +12,10 @@ class Measure < VersionedRecord | |||
| has_many :due_dates, through: :indicators | |||
| has_many :progress_reports, through: :indicators | |||
|
|
|||
| belongs_to :parent, class_name: "Measure", required: false | |||
There was a problem hiding this comment.
I don't think measures have parent measures here
| add_column :indicators, :relationship_updated_at, :datetime, precision: 6, null: true | ||
| add_column :measures, :relationship_updated_at, :datetime, precision: 6, null: true | ||
| add_column :users, :relationship_updated_at, :datetime, precision: 6, null: true | ||
| end |
There was a problem hiding this comment.
we also want to track relationship updates to the recommendations table
There was a problem hiding this comment.
specifically recommendation_categories, recommendation_indicators, recommendation_measures and recommendation_recommendations
There was a problem hiding this comment.
no need to track changes to sdgtargets btw - in fact as we no longer use they could/should also be dropped
There was a problem hiding this comment.
finally, we should also consider tracking category relationship updates, including
- to its parent category (parent_id) and also the inverse (the parent if assigned a child)
- to its manager (manager_id) and also the inverse (the user if assigned a category)
but let's leave this for later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to bring in the developments from advocacy-tracker-server:
relationship_updated_atwhen relationship changes dumparkltd/advocacy-tracker-server#53relationship_updated_by_idwhen relationship changes dumparkltd/advocacy-tracker-server#57And from marine-defrag-server:
last_modified_user_idtoupdated_by_idmarine-defrag/marine-defrag-server#43created_by_idto all tables marine-defrag/marine-defrag-server#42Resolves #362