Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: addons admin page to use react-aria-components instead of @reach/tabs #6876

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Refactor: addons admin page to use react-aria-components instead of @reach/tabs #6876

merged 1 commit into from
Aug 16, 2023

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Aug 16, 2023 •
edited
Loading

Description

Reach UI is not currently maintained and will not be supporting later version of React. This PR uses a recommended alternative library called react-aria-components (maintained by adobe - spectrum) as a drop in replacement for our usage of @reach/tabs in the addon admin page.

Affects

The addon admins page

Visuals

Screenshot 2023-08-16 at 9 43 07 AM

Testing Instructions

  • Build assets (might need to use --legacy-peer-deps for now
  • View the "Add-ons" page
  • Make sure it looks the same

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review August 16, 2023 13:47
@jonwaldstein
Copy link
Contributor Author

@JoshuaHungDinh this is ready for review.

JoshuaHungDinh
JoshuaHungDinh approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works & looks fine. I cant seem to get it to pass static analysis but it does not look like its being introduced by this PR.

@jonwaldstein jonwaldstein merged commit 244e45f into epic/givewp-3.0 Aug 16, 2023
2 of 16 checks passed
@jonwaldstein jonwaldstein deleted the refactor/addons-admin-page branch August 16, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaHungDinh JoshuaHungDinh JoshuaHungDinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonwaldstein @JoshuaHungDinh