Skip to content

Fishing part 1 : The Fishing Rod#1482

Merged
mqole merged 13 commits intoimpstation:masterfrom
Saeko-44:master
Feb 10, 2025
Merged

Fishing part 1 : The Fishing Rod#1482
mqole merged 13 commits intoimpstation:masterfrom
Saeko-44:master

Conversation

@Saeko-44
Copy link
Copy Markdown

About the PR

Im PR'ing the fishing rod part of the fishing system before I continue further so that I may get feedback on my code so far and maybe player feedback of how it feels in game if yall think this is worth merging so far
Changelog

🆑

  • add: The fishing rod, capable of reeling things in, as a tier 1 civilian tech

@mqole
Copy link
Copy Markdown
Member

mqole commented Jan 25, 2025

dont merge yet i still need to do inhands

@kipdotnet
Copy link
Copy Markdown

want me to convert this to draft until then?

@mqole
Copy link
Copy Markdown
Member

mqole commented Jan 25, 2025

go 4 it

Comment thread Resources/Prototypes/_Impstation/Entities/Structures/Machines/lathe.yml Outdated
Comment thread Content.Shared/_Impstation/Fishing/FishingRodComponent.cs Outdated
Comment thread Content.Shared/_Impstation/Fishing/SharedFishingSystem.cs
@kipdotnet kipdotnet marked this pull request as draft January 26, 2025 02:23
@dvir001
Copy link
Copy Markdown

dvir001 commented Jan 26, 2025

space-wizards#32378

@Saeko-44 Saeko-44 marked this pull request as ready for review February 9, 2025 15:35
Copy link
Copy Markdown
Member

@mqole mqole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my end! seems like fishingrod is pulling from the rope.png of the grapple gun but that's whatever, we can fix it later. excited to test this!

@mqole mqole merged commit e0b4c5d into impstation:master Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants