Add support for unshaded displacements#1560
Merged
Darkmajia merged 6 commits intoimpstation:masterfrom Feb 10, 2025
Merged
Conversation
added 5 commits
February 4, 2025 10:39
… twice but this gives me more time to think. And I don't know the good ways to do it.
Author
|
unmarked as draft because upstream is taking infinity billion years to even review the PR i sent there |
Darkmajia
approved these changes
Feb 10, 2025
Darkmajia
left a comment
Darkmajia
left a comment
There was a problem hiding this comment.
looks good, got a thumbs up upstream as well. im sure reviews will pour in on that pr after i merge this and we'll have to change 10 million things but until then,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does some small changes to DisplacementMapSystem & adds a new unshaded displacement shader to allow for unshaded displacement maps.
No cl; not really player facing.
Content.client.2025.02.04.-.11.10.50.02.mp4