Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR FUCKING REAL THIS TIME. turns out i was onto something with #1358 but i didn't connect the dots properly. the issue was that fonts were attempting to be validated server-side, but the server build doesnt actually contain any of the resources, so the check would fail every time and give the default font
to remedy this, the check is made clientside, displaying a default font if the font couldnt be validated via prototype. fonts are also registered through prototypes instead of raw paths because, to be honest, it was kind of dumb to do it that way to begin with. HOPEFULLY I DONT HAVE TO THINK ABOUT THIS SYSTEM EVER AGAIN
i would really like to have used
ProtoId<FontPrototype>
for fonts instead of treating them as raw strings, but there's an upstream todo for movingFontPrototype
from robust client to shared, so.. upstream issueChangelog
🆑