Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signature fix for real this time #1593

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

Darkmajia
Copy link

FOR FUCKING REAL THIS TIME. turns out i was onto something with #1358 but i didn't connect the dots properly. the issue was that fonts were attempting to be validated server-side, but the server build doesnt actually contain any of the resources, so the check would fail every time and give the default font

to remedy this, the check is made clientside, displaying a default font if the font couldnt be validated via prototype. fonts are also registered through prototypes instead of raw paths because, to be honest, it was kind of dumb to do it that way to begin with. HOPEFULLY I DONT HAVE TO THINK ABOUT THIS SYSTEM EVER AGAIN

i would really like to have used ProtoId<FontPrototype> for fonts instead of treating them as raw strings, but there's an upstream todo for moving FontPrototype from robust client to shared, so.. upstream issue

Changelog
🆑

  • fix: Signature fonts should, hopefully, well and truly, finally be fixed.

Copy link

@kipdotnet kipdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I dont have a way to actually test this so ill take your word for it

@kipdotnet kipdotnet merged commit 9d0ca1f into impstation:master Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants