Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armor vests for detective and brigmed #1608

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

Sha-Seng
Copy link

@Sha-Seng Sha-Seng commented Feb 8, 2025

avian requested that i add this since it varies the fit options and because they can just grab em from the sec vendor anyway

suit + plate carrier is a cool look

it does offer slightly increased slash/blunt resist to brigmed (and slightly reduced puncture resist) but as i say, people who wanna play with the stats can just go grab one in the department anyway anyway

detective's armor's the same as the standard vests so nothing changes there

🆑

  • add: Detectives and brigmeds can now spawn with sec armor vests if they wanna

it was requested that i add this since it varies the fit options and because they can just grab em from the sec vendor anyway

suit + plate carrier is a cool look

it does offer slightly increased slash/blunt resist to brigmed (and slightly reduced puncture resist) but as i say, people who wanna play with the stats can just go grab one anyway

detective's armor's the same as the standard vests so nothing changes there
@AvianMaiden
Copy link

Yay!!

@mqole
Copy link

mqole commented Feb 8, 2025

worth noting that even though armor vests can be gotten from secvend, theres a limited amount for a reason, so regardless of intent this Is a balance pr

@Sha-Seng
Copy link
Author

Sha-Seng commented Feb 8, 2025

yeah, so the question is if +1 armor vest is too much to add the style options for. but if the brigmed spawns with that, they won't spawn with their armored medical gown. it wouldn't be +2 since detective can already spawn with an equally good armor vest, so that's an equivalent trade

it seems kinda fine to me but i don't play brigmed and don't really have a dog in that race

@AvianMaiden
Copy link

Detectives have equivalent (if not better armor), but for the brigmed I can see that. It's a really minor trade but slightly better armor, but no worries

@Sha-Seng
Copy link
Author

Sha-Seng commented Feb 8, 2025

if i recall, the specific numbers for the vest are something like 15% more slash, 10% blunt, 5% less pierce, and like 15% less caustic but who cares about that

i am totally fine removing this from brigmed if we want but i still don't think those numbers are gonna significantly change in what it takes to kill you? if it's nukies or a dragon, brigmed will be in the hardsuit anyway. heretic magic kinda bypass sec armor, and so on

the brigmed gown looks kinda weird but also idk if their uniform's worth folding and wearing with a vest anyway? your call. detective's absolutely should though yeah

@Darkmajia
Copy link

looking into it, the detective armor is parented to the basic armor this pr introduces, so there really is zero difference besides swag. no issues here

the armored medical gown is less combat-capable than the basic armor vest (though it has slightly more piercing resistance which is usually the most ideal stat to have for combat?) so i'm not sure how i feel about it. its not a major difference and i dont think people are going to be choosing armor purely for melee combat advantage, but it is A Thing

the exact numbers, in terms of reductions, are:

stat armor vest armored medical gown
blunt 30% 20%
slash 30% 15%
piercing 30% 35%
heat 20% 15%
caustic 75%
explosion 10%

given it's swapping an armored medical gown out of the economy from a job spawning in and replacing it with an armor vest, i dont really have an issue on that front. the boring answer would be to just parent the gown to the basic armor vest and let it inherit resistances, but that doesnt seem ideal

@AvianMaiden
Copy link

woah holy shit a handy graph

@Sha-Seng
Copy link
Author

Sha-Seng commented Feb 8, 2025

oh that's actually super helpful thank you. yeah, like...idrk what to do about it, I'm just presenting the option for opinions. idek who statted this medical gown

@Darkmajia
Copy link

its an upstream item, brigmed was just removed from jobs but most of the equipment we have is leftovers

@AvianMaiden
Copy link

I think brigmed could benefit from more unique stuff but that's a different thing entirely; might have to brainstorm up some cosmetics and whatnot

Copy link

@mqole mqole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still have some hangups but those are mostly to do with wanting people to interact with vending machines insteada just spawnin with it all... it aint too big a deal though. & as mentioned, itd replace existing armour in loadout, so seems pretty ok

@mqole mqole merged commit c9de648 into impstation:master Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants