Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command prestige gear #314

Merged
merged 10 commits into from
Sep 22, 2024

Conversation

Sha-Seng
Copy link

@Sha-Seng Sha-Seng commented Sep 21, 2024

🆑

  • add: Captain now has a whole 50-hour prestige set (functionally identical!)
  • tweak: Adjusted the Captain's sword sheath to stop covering our pretty uniform belts with a plain brown line
  • add: All Command spawns with a command survival box (CE gets an extended one, HoS gets a special gas mask!)
  • add: All Command now have 50-hour prestige bag and headset options
  • add: A cool box of cigarettes hehe

Adds a whole prestige set (50 hours) to Captain, adds prestige command headsets to Captain and HoP, and gives all command a prestige bag set.
It's just a comment but I accidentally deleted it hehe
Since it has different stats and they wear a lot of black.  The white masks I made look good with all other command uniforms, I think.  If people want it I could make a black armored version of the command breath mask but I'll wait for feedback.
@Sha-Seng
Copy link
Author

test1
yaaay i hope you like it i spent like a week working on it

what is tobacoo
what is tobacoo
@Darkmajia
Copy link

the VeteranCommand loadout group only needs to be defined once, putting it in every group is throwing errors. probably just leave it in captain and get rid of the others? maybe theres a better spot for it but idk

@iaada
Copy link

iaada commented Sep 21, 2024

I'm guessing that linter is getting upset that you've copy pasted a few prototypes. From a glance probably the 50 hour command timer and command bags. What you need to do is create a new yml file where all of that is defined a single time. You don't need an individual copy in each of the command role files, because all of those files are getting mashed together and read before loadout-groups.yml starts looking for the loadout prototypes.

For example on my similar PR, you can see that all of my loadouts are defined a single time in one file. Those singular loadouts then get re-used multiple times in different loadoutGroups.

@Sha-Seng
Copy link
Author

Ohh, awesome! I didn't know that was possible, but I should've tried that out. I was in such a rush to finish last night I just kept chugging along. I'll implement that when I'm free in a few hours. Thanks so much!

- type: loadoutEffectGroup
id: VeteranCommand
effects:
- !type:JobRequirementLoadoutEffect
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've copied this object across multiple files with the same ID, which is causing YML errors. Please define it once and delete every other instance of it.

Copy link
Author

@Sha-Seng Sha-Seng Sep 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They said that already, I'm doing it now! I just freed up for the day. But thank you for the feedback! Since I was having to change so many files I fell under the impression that loadouts would be per-file, not squished together before processing.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad! I just jumped straight into the "Files Changed" tab 😅

Added veteran (50-hour) headsets for all command, added the option to select basic or on-ear headsets when spawning, added a special HoS gas mask, and added a special flask to the command survival box.
@Sha-Seng
Copy link
Author

image
Ok, I fixed those problems and also added other command veteran headsets, an HoS-specific gas mask, and a special flask to the command survival box. It felt incomplete otherwise. I hope you like it! I didn't see any errors this time.

Copy link
Author

@Sha-Seng Sha-Seng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok wait fixed a tiny typo hehe dw abt it

@formlessnameless formlessnameless merged commit 0cf19b4 into impstation:master Sep 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants