unexpose unnecessary methods of Transport

imroc · Aug 5, 2023 · bee1599 · bee1599
1 parent e6a9abf
commit bee1599
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 45 deletions.
diff --git a/client.go b/client.go
@@ -881,7 +881,15 @@ func (c *Client) SetCommonHeadersNonCanonical(hdrs map[string]string) *Client {
 //	    "accept-encoding",
 //	).Get(url
 func (c *Client) SetCommonHeaderOrder(keys ...string) *Client {
-	c.SetHeaderOrder(keys...)
+	c.Transport.WrapRoundTripFunc(func(rt http.RoundTripper) HttpRoundTripFunc {
+		return func(req *http.Request) (resp *http.Response, err error) {
+			if req.Header == nil {
+				req.Header = make(http.Header)
+			}
+			req.Header[HeaderOderKey] = keys
+			return rt.RoundTrip(req)
+		}
+	})
 	return c
 }
 
@@ -897,7 +905,15 @@ func (c *Client) SetCommonHeaderOrder(keys ...string) *Client {
 //	    ":method",
 //	)
 func (c *Client) SetCommonPseudoHeaderOder(keys ...string) *Client {
-	c.SetPseudoHeaderOder(keys...)
+	c.Transport.WrapRoundTripFunc(func(rt http.RoundTripper) HttpRoundTripFunc {
+		return func(req *http.Request) (resp *http.Response, err error) {
+			if req.Header == nil {
+				req.Header = make(http.Header)
+			}
+			req.Header[PseudoHeaderOderKey] = keys
+			return rt.RoundTrip(req)
+		}
+	})
 	return c
 }
 

diff --git a/transport.go b/transport.go
@@ -214,49 +214,6 @@ func (t *Transport) WrapRoundTrip(wrappers ...HttpRoundTripWrapper) *Transport {
 	return t
 }
 
-// SetHeaderOrder set the order of the http header (case-insensitive).
-// For example:
-//
-//	t.SetHeaderOrder(
-//	    "custom-header",
-//	    "cookie",
-//	    "user-agent",
-//	    "accept-encoding",
-//	)
-func (t *Transport) SetHeaderOrder(keys ...string) {
-	t.WrapRoundTripFunc(func(rt http.RoundTripper) HttpRoundTripFunc {
-		return func(req *http.Request) (resp *http.Response, err error) {
-			if req.Header == nil {
-				req.Header = make(http.Header)
-			}
-			req.Header[HeaderOderKey] = keys
-			return rt.RoundTrip(req)
-		}
-	})
-}
-
-// SetPseudoHeaderOder set the order of the pseudo http header (case-insensitive).
-// Note this is only valid for http2 and http3.
-// For example:
-//
-//	t.SetPseudoHeaderOrder(
-//	    ":scheme",
-//	    ":authority",
-//	    ":path",
-//	    ":method",
-//	)
-func (t *Transport) SetPseudoHeaderOder(keys ...string) {
-	t.WrapRoundTripFunc(func(rt http.RoundTripper) HttpRoundTripFunc {
-		return func(req *http.Request) (resp *http.Response, err error) {
-			if req.Header == nil {
-				req.Header = make(http.Header)
-			}
-			req.Header[PseudoHeaderOderKey] = keys
-			return rt.RoundTrip(req)
-		}
-	})
-}
-
 // DisableAutoDecode disable auto-detect charset and decode to utf-8
 // (enabled by default).
 func (t *Transport) DisableAutoDecode() *Transport {