Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #351 - fix false positive on no_nested_try_catch #369

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

bormilan
Copy link
Contributor

@bormilan bormilan commented Oct 31, 2024

Description

The same as here

Maybe I should add more tests, If you have suggestions, feel free to comment. Thanks!

Closes #351.

@elbrujohalcon elbrujohalcon changed the title fix no_nested_try_catch Closes #351 - fix false positive on no_nested_try_catch Oct 31, 2024
Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would extend the test as I suggested, but… other than that, I think this is great.

test/examples/pass_no_nested_try_catch.erl Outdated Show resolved Hide resolved
@elbrujohalcon elbrujohalcon merged commit 919fa6f into inaka:main Nov 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on no_nested_try_catch
2 participants