Improve version detection #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdesmet
force-pushed
the
improve-version-detection
branch
from
bfc4efe to
f2523b4
Compare
peterdesmet
approved these changes
Jan 16, 2024
|
1 failing test (which now returns a nicer result), fixed in 934b5f9. |
PietrH
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Small suggestion to use stringr modifiers: https://stringr.tidyverse.org/reference/modifiers.html to ensure you are using the right kind of matching. Not essential in this case so I'll leave it up to you how defensive you want to be.
Well done, you turned this around very quickly and elegantly!
…amtraptor into improve-version-detection
Co-authored-by: Pieter Huybrechts <[email protected]>
Based on force pushed f2523b4. I had to solve better some small conflicts.
…amtraptor into improve-version-detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
NEWS.md