Skip to content

Add logo to readme#300

Merged
PietrH merged 7 commits intomainfrom
270-create-hex-logo
Apr 15, 2024
Merged

Add logo to readme#300
PietrH merged 7 commits intomainfrom
270-create-hex-logo

Conversation

@PietrH
Copy link
Copy Markdown
Member

@PietrH PietrH commented Mar 21, 2024 •
edited
Loading

#270 created a logo for the package, this PR adds it to the readme.

  • Check logo link
  • Add Nele as contributor
  • check failing test

@PietrH PietrH linked an issue Mar 21, 2024 that may be closed by this pull request
Create hex logo #270
Closed
@PietrH PietrH marked this pull request as ready for review March 21, 2024 14:43
@PietrH
Copy link
Copy Markdown
Member Author

PietrH commented Mar 21, 2024

We could consider uploading a higher quality logo, but this is not default behaviour in usethis. Probably to keep the page loading time down.

@PietrH
Copy link
Copy Markdown
Member Author

PietrH commented Mar 21, 2024

I'm not sure why tests are failing

peterdesmet
peterdesmet requested changes Mar 21, 2024
View reviewed changes
Comment thread README.Rmd
@PietrH
Copy link
Copy Markdown
Member Author

PietrH commented Apr 9, 2024 •
edited
Loading

@NeleMullens Made a mockup of a version with a red background.

camtraptor_logo_lexend_red

@PietrH
Copy link
Copy Markdown
Member Author

PietrH commented Apr 9, 2024

Checked with https://www.color-blindness.com/coblis-color-blindness-simulator/

@PietrH
Copy link
Copy Markdown
Member Author

PietrH commented Apr 10, 2024

There was a tiny issue on the right lower corner of the hexagon, where a part of the background was bleeding into the black border. I filled it in with black:

camtraptor_logo_lexend_red_fix

I've also included the sRGB colour profile, and stored it as an interlaced PNG for quicker loading. Not sure that those changes will matter at all because usethis converts the image with imagemagick anyway.

@NeleMullens
Copy link
Copy Markdown
Contributor

NeleMullens commented Apr 10, 2024

Love the logo @PietrH, for me this is fine. Feels very Jurassic to me

@PietrH PietrH self-assigned this Apr 10, 2024
@PietrH PietrH marked this pull request as draft April 10, 2024 12:22
@PietrH @NeleMullens
Logo with red background and foliage
32c1fe4 
Co-Authored-By: Nele Mullens <48283120+nelemullens@users.noreply.github.com>
@PietrH PietrH marked this pull request as ready for review April 10, 2024 12:26
This was referenced Apr 10, 2024
Closed
Closed
@PietrH PietrH requested a review from peterdesmet April 10, 2024 14:20
@PietrH
Copy link
Copy Markdown
Member Author

PietrH commented Apr 10, 2024

Ready for review, should be able to merge if we agree on the logo.

peterdesmet
peterdesmet approved these changes Apr 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@peterdesmet peterdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! 🦖 Thanks @NeleMullens!

@PietrH PietrH merged commit f62b937 into main Apr 15, 2024
@damianooldoni damianooldoni deleted the 270-create-hex-logo branch April 29, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterdesmet peterdesmet peterdesmet approved these changes

@damianooldoni damianooldoni damianooldoni approved these changes

Assignees

@PietrH PietrH

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create hex logo

4 participants

@PietrH @NeleMullens @peterdesmet @damianooldoni