Driver testing enhancement and minor refactoring #2341
Merged
+42
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driver testing enhancement: Making so that you can write drivers in your testing unikernel. Currently you need to modify large portions of the codebase to hack a driver and it needs to be part of source. This allows constructing driver objects directly in your main/service. Minor refactoring: Moving defines from source to header files
|
It's not a problem this time, but do keep in mind squashing commits makes it harder to review the changes. Making one commit to move the defines from one file to another, and another to add new features would have made it easier to track changes and be able to verify what's new and what's just refactored. I'll see if the tests pass in a minute. Also, for reference: #2333. |
|
Tests are green :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver testing enhancement:
Making so that you can write drivers in your testing unikernel. Currently you need to modify large portions of the codebase to hack a driver and it needs to be part of source. This allows constructing driver objects directly in your main/service.
Minor refactoring:
Moving defines from source to header files