Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilisation du mécanisme "est défini" pour les booléens (NGC-214) #2147

Closed
wants to merge 10 commits into from

Conversation

Clemog
Copy link
Contributor

@Clemog Clemog commented Nov 3, 2023

@Clemog Clemog requested a review from EmileRolley November 3, 2023 10:50
Copy link

github-actions bot commented Nov 3, 2023

Report for the pull request #2147

🚀 Test the model from the website: https://nosgestesclimat.fr?PR=2147


🔧 Model compilation status

Task Status Message
Supported regions ✔️ Ø
Successfully compiled and optimized rules:
Expand
  • FR-fr
  • BE-fr
  • CA-fr
  • CH-fr
  • DE-fr
  • GF-fr
  • GP-fr
  • IT-fr
  • LU-fr
  • MQ-fr
  • PF-fr
  • PL-fr
  • PT-fr
  • RE-fr
  • TN-fr
  • TR-fr
  • UK-fr
  • YT-fr
  • FR-en
  • BE-en
  • CA-en
  • CH-en
  • DE-en
  • GF-en
  • GP-en
  • IT-en
  • LU-en
  • MQ-en
  • PF-en
  • PL-en
  • PT-en
  • RE-en
  • TN-en
  • TR-en
  • UK-en
  • YT-en
✔️ Ø
Personas compilation to JSON for fr ✔️ Ø
Personas compilation to JSON for en ✔️ Ø

🌐 Translation status

Rules

Language Nb. missing translations Status
en
Missing 5 rules ⬇️
  • alimentation . boisson . eau en bouteille > titre
  • alimentation . boisson . eau en bouteille . consommateur > titre
  • logement . climatisation . nombre par défaut > note
  • logement . climatisation . nombre par défaut > titre
  • logement . piscine . empreinte moyenne > titre

Personas

Language Nb. missing translations Status
en Ø ✔️

You will find more information about the translation in the dedicated file.


👫 Personas changes

Test personas regression

Persona Total PR (kg CO2e) Total in prod. (kg CO2e) Δ (%)
9,347.832 9,320.755 +0%
9,370.401 9,350.545 +0%
8,127.287 8,067.718 +1%
6,453.526 6,344.516 +2%
9,365.524 9,335.9 +0%

Test model optimisation

Persona Total PR with optim. (kg CO2e) Total PR without optim. (kg CO2e) Δ (%)

@Clemog Clemog changed the title Utilisation du mécanisme "est défini" pour les booléens Utilisation du mécanisme "est défini" pour les booléens (NGC-214) Nov 3, 2023
Copy link

@Clemog
Copy link
Contributor Author

Clemog commented Nov 16, 2023

@JuliePouliquen si tu veux essayer de tester via https://preprod.nosgestesclimat.fr/simulateur/bilan?PR=2147 c'est top :)

Copy link
Contributor

@EmileRolley EmileRolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trop coolos ❤️

data/logement/piscine.publicodes Outdated Show resolved Hide resolved
data/logement/piscine.publicodes Show resolved Hide resolved
@JuliePouliquen
Copy link
Contributor

Hello @Clemog j'ai bien testé et tout me semble OK ! Il va me falloir un peu de temps pour m'habituer à utiliser "est défini" mais ça va le faire :). Trop bien en tous cas !

@Clemog
Copy link
Contributor Author

Clemog commented Dec 6, 2023

Je ferme au profit de #2181 qui prend déjà cette PR en compte :)

@Clemog Clemog closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants