Skip to content

Add tests for REST API#1035

Closed
fabienheureux wants to merge 5 commits intomainfrom
add-tests-for-rest-api
Closed

Add tests for REST API#1035
fabienheureux wants to merge 5 commits intomainfrom
add-tests-for-rest-api

Conversation

@fabienheureux
Copy link
Copy Markdown
Member

Description succincte du problème résolu

J'ai ajouté des petits tests pour l'API, cf #1034

@fabienheureux fabienheureux requested a review from a team as a code owner November 15, 2024 10:29
@fabienheureux fabienheureux requested review from kolok and maxcorbeau and removed request for a team November 15, 2024 10:29
Copy link
Copy Markdown
Contributor

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention, il y a un test qui plante

Comment thread integration_tests/qfdmo/test_api.py
Comment thread integration_tests/qfdmo/test_api.py
Comment thread integration_tests/qfdmo/test_api.py

@pytest.mark.django_db
def test_autocomplete_epci(client):
"""Test the /autocomplete/configurateur endpoint"""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce qu'il ne faut pas mock l'appel à l'API des EPCI pour ne pas en dépendre dans les tests ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'y ai pensé, j'ai un peu flemmé 😬

@kolok kolok assigned fabienheureux and unassigned kolok Nov 19, 2024
Copy link
Copy Markdown
Contributor

@maxcorbeau maxcorbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remarques sur:

  • mutualisations constantes
  • chaînes vides
  • flagger dans ta PR les changements de modèles

Comment thread qfdmo/api.py
Comment thread qfdmo/fixtures/actions.json
Comment thread qfdmo/models/action.py
@fabienheureux fabienheureux force-pushed the add-tests-for-rest-api branch 2 times, most recently from 9958562 to bd1dcab Compare November 19, 2024 20:35
@fabienheureux fabienheureux mentioned this pull request Dec 11, 2024
@fabienheureux fabienheureux force-pushed the add-tests-for-rest-api branch from 3a7d9fe to 8bf15fc Compare March 17, 2025 09:51
@fabienheureux
Copy link
Copy Markdown
Member Author

embarquée dans #1556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants