Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWF-158: Fix typo IdReusePolicy of ALLOW_IF_PREVIOUS_EXISTS_ABNORMALL… #79

Closed
wants to merge 1 commit into from

Conversation

stevo89519
Copy link
Contributor

Looks like a lot, but it was just updating the iwf-idl submodule and refreshing the generated code.

@stevo89519
Copy link
Contributor Author

let me know if I shouldn't commit the refreshed generated code and only commit the submodule reference update.

@longquanzheng
Copy link
Contributor

let me know if I shouldn't commit the refreshed generated code and only commit the submodule reference update.

There is a breaking changes in open api for Golang … we need to pin it like this before we can fix the breaking changes indeedeng/iwf#375

@mixydubs
Copy link

let me know if I shouldn't commit the refreshed generated code and only commit the submodule reference update.

There is a breaking changes in open api for Golang … we need to pin it like this before we can fix the breaking changes indeedeng/iwf#375

@longquanzheng should we be looking at upgrading openapi and fixing the breaking changes?

@longquanzheng
Copy link
Contributor

let me know if I shouldn't commit the refreshed generated code and only commit the submodule reference update.

There is a breaking changes in open api for Golang … we need to pin it like this before we can fix the breaking changes indeedeng/iwf#375

@longquanzheng should we be looking at upgrading openapi and fixing the breaking changes?

Yes we should. But I’m not sure how much time it will take, I tried to do that on server, it looks quite complicated

@stevo89519
Copy link
Contributor Author

stevo89519 commented Sep 27, 2024

Created a separate pull request here. Pinned the api generator and did not refresh the generated code.
Closing this request.

@stevo89519 stevo89519 closed this Sep 27, 2024
@stevo89519 stevo89519 deleted the jira/sharrison/IWF-158 branch October 1, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants