Skip to content

Commit

Permalink
Fix NDE for setting version at start
Browse files Browse the repository at this point in the history
  • Loading branch information
longquanzheng committed Mar 9, 2024
1 parent 5debdce commit e76b330
Show file tree
Hide file tree
Showing 12 changed files with 627 additions and 32 deletions.
2 changes: 1 addition & 1 deletion docker-compose/.env
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ ELASTICSEARCH_VERSION=7.16.2
MYSQL_VERSION=8
POSTGRESQL_VERSION=13
TEMPORAL_VERSION=1.22.4
TEMPORAL_UI_VERSION=2.23.0
TEMPORAL_UI_VERSION=2.22.3
5 changes: 3 additions & 2 deletions integ/basic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package integ

import (
"context"
config2 "github.com/indeedeng/iwf/service/common/config"
"github.com/indeedeng/iwf/service/common/ptr"
"log"
"strconv"
Expand Down Expand Up @@ -51,8 +52,8 @@ func doTestBasicWorkflow(t *testing.T, backendType service.BackendType, config *
defer closeFunc1()

_, closeFunc2 := startIwfServiceByConfig(IwfServiceTestConfig{
BackendType: backendType,
SetVersionAtStart: true,
BackendType: backendType,
OptimizationVersion: ptr.Any(config2.OptimizationVersionNone),
})
defer closeFunc2()

Expand Down
8 changes: 4 additions & 4 deletions integ/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ import (
const testWorkflowServerPort = "9714"
const testIwfServerPort = "9715"

func createTestConfig(failAtMemoCompatibility bool, setVersionAtStart bool) config.Config {
func createTestConfig(failAtMemoCompatibility bool, optimizationVersion *int) config.Config {
return config.Config{
Api: config.ApiConfig{
Port: 9715,
MaxWaitSeconds: 10, // use 10 so that we can test it in the waiting test
SetVersionAtStart: setVersionAtStart,
Port: 9715,
MaxWaitSeconds: 10, // use 10 so that we can test it in the waiting test
OptimizationVersion: optimizationVersion,
},
Interpreter: config.Interpreter{
VerboseDebug: false,
Expand Down
Loading

0 comments on commit e76b330

Please sign in to comment.