Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NDE for setting version at start #374

Merged
merged 3 commits into from
Mar 16, 2024
Merged

Fix NDE for setting version at start #374

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e76b330
Fix NDE for setting version at start
longquanzheng Mar 9, 2024
bd4c00f
fix todo
longquanzheng Mar 9, 2024
ee1506f
remove defaul
longquanzheng Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ ELASTICSEARCH_VERSION=7.16.2
MYSQL_VERSION=8
POSTGRESQL_VERSION=13
TEMPORAL_VERSION=1.22.4
TEMPORAL_UI_VERSION=2.23.0
TEMPORAL_UI_VERSION=2.22.3
5 changes: 3 additions & 2 deletions integ/basic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package integ

import (
"context"
config2 "github.com/indeedeng/iwf/service/common/config"
"github.com/indeedeng/iwf/service/common/ptr"
"log"
"strconv"
Expand Down Expand Up @@ -51,8 +52,8 @@ func doTestBasicWorkflow(t *testing.T, backendType service.BackendType, config *
defer closeFunc1()

_, closeFunc2 := startIwfServiceByConfig(IwfServiceTestConfig{
BackendType: backendType,
SetVersionAtStart: true,
BackendType: backendType,
OptimizationVersion: ptr.Any(config2.OptimizationVersionNone),
})
defer closeFunc2()

Expand Down
8 changes: 4 additions & 4 deletions integ/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ import (
const testWorkflowServerPort = "9714"
const testIwfServerPort = "9715"

func createTestConfig(failAtMemoCompatibility bool, setVersionAtStart bool) config.Config {
func createTestConfig(failAtMemoCompatibility bool, optimizationVersion *int) config.Config {
return config.Config{
Api: config.ApiConfig{
Port: 9715,
MaxWaitSeconds: 10, // use 10 so that we can test it in the waiting test
SetVersionAtStart: setVersionAtStart,
Port: 9715,
MaxWaitSeconds: 10, // use 10 so that we can test it in the waiting test
OptimizationVersion: optimizationVersion,
},
Interpreter: config.Interpreter{
VerboseDebug: false,
Expand Down
Loading
Loading