IWF-105: Add event logger #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwolczynski
force-pushed
the
jira/lwolczynski/IWF-105
branch
from
6f2395e to
8bec18e
Compare
lwolczynski
force-pushed
the
jira/lwolczynski/IWF-105
branch
from
7891697 to
2afa674
Compare
mixydubs
reviewed
Nov 18, 2024
service/common/logevent/logevent.go
Outdated
| import "github.com/indeedeng/iwf/gen/iwfidl" | ||
|
|
||
| // The implementation must be lightweight, reliable and fast (less than 1s) | ||
| type LogEventFunc func(event iwfidl.IwfEvent) |
There was a problem hiding this comment.
Sorry for changing my mind on naming -- since this is event, maybe calling it "HandleEventFunc"?
because it may not be logging -- we may be sending to Kafka and consuming for DB etc
|
Lgtm otherwise |
lwolczynski
force-pushed
the
jira/lwolczynski/IWF-105
branch
from
78e3985 to
72d1587
Compare
| @@ -0,0 +1,16 @@ | |||
| package handleevent | |||
There was a problem hiding this comment.
maybe package event?
An the other places it's event.Handler(...)
longquanzheng
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Related Issue
Closes #issue_number