Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cadence starting issue in docker compose #528

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Fix Cadence starting issue in docker compose #528

merged 2 commits into from
Dec 23, 2024

Conversation

lwolczynski
Copy link
Contributor

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is not backwards compatible)

Related Issue

Closes #issue_number

@lwolczynski lwolczynski mentioned this pull request Dec 20, 2024
Closed
5 tasks
@longquanzheng longquanzheng changed the title Fix Cadence start Fix Cadence starting issue in docker compose Dec 20, 2024
longquanzheng
longquanzheng approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!!!

@lwolczynski lwolczynski marked this pull request as ready for review December 20, 2024 22:08
@lwolczynski lwolczynski linked an issue Dec 20, 2024 that may be closed by this pull request
Docker compose is flaky with Cadence using Kafka, probably just upgrade Cadence #458
Closed
@lwolczynski lwolczynski merged commit 4e9aec8 into jira/holiday/IWF-435 Dec 23, 2024
8 checks passed
@lwolczynski lwolczynski deleted the fix-cadence-start branch December 23, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longquanzheng longquanzheng longquanzheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker compose is flaky with Cadence using Kafka, probably just upgrade Cadence
2 participants
@lwolczynski @longquanzheng