Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

PROC-1479: Add force logging field #162

Merged
merged 2 commits into from
Apr 11, 2024
Merged

PROC-1479: Add force logging field #162

merged 2 commits into from
Apr 11, 2024

Conversation

zacharygoodwin
Copy link
Contributor

No description provided.

@zacharygoodwin zacharygoodwin self-assigned this Apr 9, 2024
jamesallen-indeed
jamesallen-indeed approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@jamesallen-indeed jamesallen-indeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I was hoping there would be less boilerplate. Is it worth trying to take advantage of lombok?

@zacharygoodwin
Copy link
Contributor Author

LGTM!

I was hoping there would be less boilerplate. Is it worth trying to take advantage of lombok?

Yes, but I think we should have that has a follow up ticket to clean up the various model classes.

@zacharygoodwin zacharygoodwin merged commit 39e0924 into indeedeng:master Apr 11, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamesallen-indeed jamesallen-indeed jamesallen-indeed approved these changes

@vanhaxl vanhaxl Awaiting requested review from vanhaxl

@stevenchen-indeed stevenchen-indeed Awaiting requested review from stevenchen-indeed

Assignees

@zacharygoodwin zacharygoodwin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharygoodwin @jamesallen-indeed