Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorbet to flutter #9

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add sorbet to flutter #9

wants to merge 4 commits into from

Conversation

ankitagupta12
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #9 (0e52cf4) into main (5ff528e) will decrease coverage by 9.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   92.99%   83.75%   -9.24%     
==========================================
  Files           8        8              
  Lines         314      314              
==========================================
- Hits          292      263      -29     
- Misses         22       51      +29     
Impacted Files Coverage Δ
lib/flutter.rb 100.00% <ø> (ø)
lib/flutter/config.rb 100.00% <ø> (ø)
lib/flutter/minitest.rb 90.47% <ø> (-9.53%) ⬇️
lib/flutter/parser.rb 90.74% <ø> (-9.26%) ⬇️
lib/flutter/persistence.rb 74.66% <ø> (-21.34%) ⬇️
lib/flutter/rspec.rb 100.00% <ø> (ø)
lib/flutter/tracker.rb 70.12% <ø> (-5.20%) ⬇️
lib/minitest/flutter_plugin.rb 100.00% <ø> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ankitagupta12 ankitagupta12 changed the title [wip] Ankita/add sorbet Add sorbet to flutter Oct 9, 2022
Copy link
Contributor

@alisaifee alisaifee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the generated files in sorbet/rbi/gems required to be checked in or can they either be added to .gitignore or something like that?

Copy link
Contributor

@alisaifee alisaifee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my noob understanding this looks good to go. As follow ups we can integrate the gem stubs validity check & type check into the CI workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants