Fix clippy lints #270
Merged
Fix clippy lints #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Jun 6, 2024
| @@ -1904,6 +1899,7 @@ fn validate_distribution( | |||
|
|
|||
| let exported = context.libpython_exported_symbols.contains(&ext.init_fn); | |||
|
|
|||
| #[allow(clippy::needless_bool, clippy::if_same_then_else)] | |||
There was a problem hiding this comment.
I opted to allow the if statements to keep their current structure though it is redundant because I find it quite clear this way and am not compelled to change the style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the code to pass
cargo clippy. Most of the fixes were auto-applied by Clippy.