Only stamp the tab header on hosts that run the recorder - #6
Merged
Conversation
pascalbaljet
marked this pull request as ready for review
July 30, 2026 08:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every tab gets a persisted UUID and a
declarativeNetRequestsession rule that stamps it asx-inertia-devtools-tab, but that rule carried no host condition. Installing the extension meant handing a stable, cross-site identifier to every site the user visits.The worker now keeps a persisted set of hosts that have proven they run the recorder, meaning they either served an
x-inertia-devtools-idresponse header or rendered thedata-inertia-devtools-idscript tag, and scopes the rule to that set throughrequestDomains. With no proven host, no rule is installed at all. Since the proof arrives with the response, a host's first response is unstamped and every request after that carries the UUID. Rules are also rewritten rather than assumed live, because session rules die on browser restart and the proven-host set grows over time.