Support apps served from a subdirectory - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension built the entry endpoint from the origin alone, so an app served from a subdirectory of its origin was requested at the wrong place and every entry was dropped. A Laravel app reached through a symlink in the document root lives at something like
/portal, which puts the endpoint at/portal/_inertia/devtools/entries/{id}while the extension asked for/_inertia/devtools/entries/{id}and got a redirect.The worker now takes the path from the recorder, either the
x-inertia-devtools-base-pathresponse header or the matching attribute on the injected id tag, and prefixes the endpoint with it. The extension never guesses the path, so this needs inertiajs/inertia-laravel#895 as well. Both values arrive from the inspected page, so the path is validated for shape and the built URL is compared against what was asked for, which rejects encoded dot segments that the URL parser would otherwise normalize out of the mount point.Fixes #4.