Call to_hash On inertia_errors for Session Serialization #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenMorganMY
force-pushed
the
fix-inertia-errors
branch
from
3e85d71
to
3aeeadd
Compare
|
I literally ran into this error last week, so would really like this change! 🚀 |
|
If I'm reading this table correctly, you've listed all the possible options, and all should be working after this change, so looks safe to merge it in! I'll update here once we get a release out with the change. |
bknoles
approved these changes
Oct 30, 2024
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As one can see in the screenshot below, if
ActiveModel::Errorsis passed as the error object, it will be stored in the session. If yourcookie_serializeris:json,:marshal, or:hybridthis will work fine. However, Rails now uses:message_packandActiveModel::Errorsdoes not respond toto_msgpack. This ensures that errors being passed are turned into a hash.