[2.x] Remove data option from useForm options type
#2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroborges
commented
Oct 24, 2024
| @@ -7,6 +7,7 @@ type setDataByObject<TForm> = (data: TForm) => void | |||
| type setDataByMethod<TForm> = (data: (previousData: TForm) => TForm) => void | |||
| type setDataByKeyValuePair<TForm> = <K extends keyof TForm>(key: K, value: TForm[K]) => void | |||
| type FormDataType = object | |||
There was a problem hiding this comment.
By the way, the FormDataType in the Svelte adapter is more specific than the other two adapters.
Suggested change
| type FormDataType = object | |
| type FormDataType = Record<string, FormDataConvertible> |
| @@ -4,6 +4,7 @@ import isEqual from 'lodash.isequal' | |||
| import { reactive, watch } from 'vue' | |||
|
|
|||
| type FormDataType = object | |||
There was a problem hiding this comment.
Suggested change
| type FormDataType = object | |
| type FormDataType = Record<string, FormDataConvertible> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inclusion of
datainVisitOptionscan be misleading when usinguseForm. We should update the type definitions to exclude thedataproperty in this context to prevent confusion.Closes #2056.