Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clientSetup) : fix react installation and initialization code. #338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arsadii
Copy link

@arsadii arsadii commented May 16, 2024

Help for beginners to start using inertia-js with react.

  • Adding the react and react-dom installation to make it clear that people need to install it.
  • Adding import from react in initialization app.jsx to make it run.

@PedroAugustoRamalhoDuarte

Good change @arsadii, i confirm the installation is working with this changes

@driesvints driesvints requested a review from reinink June 17, 2024 11:54
@reinink
Copy link
Member

reinink commented Jun 17, 2024

Hey!

So our installation instructions have never included directions on how to install React, Vue, or Svelte — only how to get Inertia up and running.

I mostly did this because I didn't want the Inertia docs to have to explain a bunch of stuff that is better found in the docs for these particular frameworks. In the same way we don't explain how to setup Vite or webpack.

That said, I do kind of agree that this change would be nice if all it means is updating the dependencies and doesn't require any extra instructions. But if we're going to do that we need to update this for all the libraries (Vue 2, Vue 3, Svelte), not just React.

Feel free to update this PR to do that, otherwise I'll try and do it when I have a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants