[query-pool] Add wrapper for Vulkan query pools #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAmNotHanni
added
the
cat:enhancement
IAmNotHanni
commented
May 8, 2021
IAmNotHanni
commented
May 8, 2021
yeetari
requested changes
May 12, 2021
IAmNotHanni
force-pushed
the
hanni/vulkan_queries
branch
from
5f2d619 to
b0f4386
Compare
|
As @yeetari pointed out we must support other types beside
https://www.khronos.org/registry/vulkan/specs/1.2-extensions/man/html/VkQueryType.html |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #280
https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#queries
I did not fully implement this yet because I think yeetari knows best where to place it inside of the rendergraph.
Keep in mind that this code is untested.