v1.0.0 alpha #154
Draft
v1.0.0 alpha #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move task.py to jax/envs/env.py
Feature/pyproject toml
…sambiguate hidden states in the past
First past of implementation for named distribution for easy manipulation and inspection of discrete conditional probability distributions.
… from @ran-weii's `complex_act_dependencies` branch
…update_state_likelihood_dirichlet()` function
…to respect new output structure of `pymdp.jax.inference.smoothing_ovf`
…date` to work properly, not using `tree_map` anymore
…ion now relegated to a `legacy` folder. Co-authored-by: Tim Verbelen <[email protected]>
…) method of `Agent`, from commit 1958e4d
- in case inductive matrix `I` is not present,do not update it when updating transition parameters. This avoids an error in `tree_at` for updating None-valued leaves (`self.I` will be None in case `self.use_inductive = False`)
…n 3.10 and to not assume a requirements.txt file. Authored by @tverbele
- started version of `T-Maze` environment in new jax `Env` class Co-authored-by: Tim Verbelen <[email protected]>
|
@conorheins fantastic to see a potential v1 of pymdp! at 97 files and 21k lines touched, I'd suggest breaking this up into sub PRs that get merged into main. Then you can pull main into this branch and then this PR will slowly get smaller over time. My general process for this is:
I'm not sure what verses have as PR guidelines, but I tend to find sub 200 lines (including tests) get the best quality reviews, but if that results in 100 PRs then relaxing this might be better 😅 |
|
Also I'm happy to help with reviewing if you upgrade my contributor status to allow me to do so 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to see how hard/easy merging in the v1.0.0 alpha changes would be at this stage