-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug: mapping from msgpack response to int, Integer, long, Long types works fine #671
base: master
Are you sure you want to change the base?
Conversation
Nice catch, one small formatting nit:
|
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
=========================================
Coverage 88.18% 88.18%
Complexity 722 722
=========================================
Files 69 69
Lines 2513 2513
Branches 268 268
=========================================
Hits 2216 2216
Misses 208 208
Partials 89 89
Continue to review full report at Codecov.
|
I'm reviewing this PR. Please, do not merge. |
Did anything ever happen with this one? |
What is a progress on this? |
Hi @fmachado, any update on this PR? |
I think he stopped working on this a long time ago. That's left a lot of PRs unmerged and most have likely gone to the influxdb-client-java repo. |
All of the unit tests of the
InfluxDBResultMapper
is based on the assumption that all numbers in response from influxd isDouble
. It will be ok withJSON
. Butmsgpack
format is more precise.So,
InfluxDBResultMapper
have errors. For example, it throws an exception when mapping number toint
,Integer
,long
,Long
types frommsgpack
responses, but works withjson
.This PR fix it (with unit test).